From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Make git-svn work with gitdir links
Date: Mon, 21 Jan 2013 15:19:19 +0100 [thread overview]
Message-ID: <kdjip9$4j7$1@ger.gmane.org> (raw)
In-Reply-To: 7vwqv7i9su.fsf@alter.siamese.dyndns.org
Junio C Hamano wrote:
> Barry Wardell <barry.wardell@gmail.com> writes:
>
>> These patches fix a bug which prevented git-svn from working with
>> repositories which use gitdir links.
>>
>> Changes since v2:
>> - Rebased onto latest master.
>> - Added test case which verifies that the problem has been fixed.
>> - Fixed problems with git svn (init|clone|multi-init).
>> - All git-svn test cases now pass (except two in t9101 which also
>> failed before these patches).
>>
>> Barry Wardell (2):
>> git-svn: Add test for git-svn repositories with a gitdir link
>> git-svn: Simplify calculation of GIT_DIR
>
> Thanks for your persistence ;-) As this is a pretty old topic, I'll
> give two URLs for people who are interested to view the previous
> threads:
>
> http://thread.gmane.org/gmane.comp.version-control.git/192133
> http://thread.gmane.org/gmane.comp.version-control.git/192127
>
> You would want to mark it as test_expect_failure in the first patch
> and then flip it to text_expect_success in the second patch where
> you fix the breakage? Otherwise, after applying the first patch,
> the testsuite will break needlessly.
I'd just apply them the other way round, 1st fix the problem, 2nd add a test
for it
Bye, Jojo
next prev parent reply other threads:[~2013-01-21 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 19:53 [PATCH v2] git-svn: Simplify calculation of GIT_DIR Barry Wardell
2012-03-08 0:51 ` Eric Wong
2013-01-21 1:22 ` [PATCH v3 0/2] Make git-svn work with gitdir links Barry Wardell
2013-01-21 1:22 ` [PATCH 1/2] git-svn: Add test for git-svn repositories with a gitdir link Barry Wardell
2013-01-21 1:22 ` [PATCH 2/2] git-svn: Simplify calculation of GIT_DIR Barry Wardell
2013-01-21 1:50 ` [PATCH v3 0/2] Make git-svn work with gitdir links Junio C Hamano
2013-01-21 14:19 ` Joachim Schmitz [this message]
2013-01-21 21:45 ` Philip Oakley
2013-01-21 22:08 ` Junio C Hamano
2013-01-23 2:32 ` Eric Wong
2013-01-23 2:53 ` Junio C Hamano
2013-01-23 12:08 ` Barry Wardell
[not found] ` <CAHrK+Z-uXAEgd_HuisbioO8=D7DEdmceeUEz3A1Jr_rtm7a3WA@mail.gmail.com>
2013-01-24 1:27 ` Eric Wong
2013-01-24 5:29 ` Junio C Hamano
2013-01-24 10:14 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kdjip9$4j7$1@ger.gmane.org' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.