All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: linux-mips@linux-mips.org
Subject: Re: MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE
Date: Thu, 21 Mar 2013 01:16:08 +0100	[thread overview]
Message-ID: <kidjg0$u10$1@ger.gmane.org> (raw)
In-Reply-To: <514A4265.2080709@gmail.com>


>> why? the mips32 74k platform (broadcom bcm4706 for instance) does
>> support huge pages.
>
> The hardware may support pages larger than 64K, but does the Linux
> kernel?  I think not.
>
>> and some of these devices are also using highmem for
>> accessing more than 128mb ram (which is totally broken in all current
>> kernels too and causing filesystem corruptions)
>> i was able to fix the highmem problem using a patch which was submitted
>> but never taken into the mainline, but i just was able to get thb
>> partially to work on mips32. but i think it would be possible to support
>> this on mips32 as well. so why leaving it out?
>
> As they say... Patches are welcome.  If you get Linux HUGE pages working
> for 32-bit kernels send a patch to enable the transparent variety as well.
>
> David Daney

the first patch would be fix for the HIGHMEM problem. all recent kernels 
do support HIGHMEM for mips32 based devices, but in fact its not 
working. all patches i made which is required to get it to work is 
available at svn://svn.dd-wrt.com/DD-WRT for all recent kernels.

for mips32 HIGHMEM support you need to apply the following patch

http://patchwork.linux-mips.org/patch/3634/

this patch has a small typo, which needs to be fixed but its very easy 
to merge to all current kernels. without it, highmem enabled devices 
will cause memory corruptions. especially on filesystems wrong data will 
be written and so on.

i will try to test my older thb patch with the new highmem fixes 
together next and i hope it works. in the meantime, please review the 
patchlink above

Sebastian

      reply	other threads:[~2013-03-21  0:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-02 20:51 THP broken on MIPS-32 [3.8] Ben Hutchings
2013-03-04  4:17 ` MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE Ben Hutchings
2013-03-04 18:13   ` David Daney
2013-03-12 14:07   ` Ralf Baechle
2013-03-20 22:33   ` Sebastian Gottschall
2013-03-20 23:12     ` David Daney
2013-03-21  0:16       ` Sebastian Gottschall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='kidjg0$u10$1@ger.gmane.org' \
    --to=s.gottschall@dd-wrt.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.