All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert.Larice@t-online.de (Robert Larice)
To: cocci@systeme.lip6.fr
Subject: [Cocci] might be bug report, breaking up of a comment
Date: Sat, 17 Feb 2018 23:06:43 +0100	[thread overview]
Message-ID: <kky3jrgtjg.fsf@bora.foobar.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1802172243470.12418@hadrien> (Julia Lawall's message of "Sat, 17 Feb 2018 22:44:13 +0100 (CET)")

Julia Lawall <julia.lawall@lip6.fr> writes:

> On Sat, 17 Feb 2018, Robert Larice wrote:
>
>> Hello,
>>
>>   attached is a small example which seems to
>>     break up a comment line,
>>     thus commenting out following lines.
>>
>>   Please look at the "long reuse" line
>>     which will have an open comment when spatch is run,
>>     thus commenting out the following "struct line *options"
>
> I also see this undesriable behavior.  Thanks for the report.
>
> julia

grepping a bit in the source code I found this:
  cpp_eat_until_nl
perhaps in the vicinity of the issue.

and there is this comment somewhere:

(* cpp recognize C comments, so when #define xx (yy) /* comment \n ... */
 * then he has already erased the /* comment. So:
 * - dont eat the start of the comment otherwise afterwards we are in the middle
 *   of a comment and so will problably get a parse error somewhere.
 * - have to recognize comments in cpp_eat_until_nl.
 *)

  reply	other threads:[~2018-02-17 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17 20:53 [Cocci] might be bug report, breaking up of a comment Robert Larice
2018-02-17 21:44 ` Julia Lawall
2018-02-17 22:06   ` Robert Larice [this message]
2018-02-17 22:43     ` Julia Lawall
2018-03-11 21:15     ` Julia Lawall
2018-03-12 17:12       ` Robert Larice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kky3jrgtjg.fsf@bora.foobar.de \
    --to=robert.larice@t-online.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.