All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frej Drejhammar <frej.drejhammar@gmail.com>
To: sarha@kapsi.fi
Cc: "Kevin Hao" <haokexin@gmail.com>,
	dri-devel@lists.freedesktop.org, "Jyri Sarha" <jyri.sarha@iki.fi>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maíra Canal" <mcanal@igalia.com>
Subject: Re: [PATCH] drm/tilcdc: Set preferred depth
Date: Tue, 19 Mar 2024 20:17:42 +0100	[thread overview]
Message-ID: <kmsqu3uax.fsf@gmail.com> (raw)
In-Reply-To: <60505d851dabcb597c5c4c1e7f76e859ff5d05a9@kapsi.fi> (sarha@kapsi.fi's message of "Tue, 19 Mar 2024 11:05:06 +0000")

Hi, Jyri

sarha@kapsi.fi writes:

> So the trouble here is the 16bpp and 24/32bpp color wiring being
> crossed, right? I'd just like to remind that there is another option
> to overcome the issue by editing device tree files. The current
> configuration from some 8 years back supports RG16, BG24, and XB24
> formats, but on Beaglebone-Black its possible - thanks to tda998x -
> change the support to BG16, RG24, and XR24, by changing these lines
> before building a new dtb-file:

I don't think that will solve the problem. The unmodified
drm_driver_legacy_fb_format() gives RG16 if it is asked for a 16 bit
depth (and the corresponding bpp in the way that the X server does) and
RG24 if asked for 24 bits. So swapping the bits around will always break
one of the hardware-supported depths unless you can cross/uncross the
wires dynamically when setting the frame buffer.

Best regards,

--Frej

      reply	other threads:[~2024-03-19 19:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-17  3:39 [PATCH] drm/tilcdc: Set preferred depth Kevin Hao
2024-03-17 19:18 ` Frej Drejhammar
2024-03-18  0:48   ` Kevin Hao
2024-03-18 19:21     ` Frej Drejhammar
2024-03-19 11:05 ` sarha
2024-03-19 19:17   ` Frej Drejhammar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kmsqu3uax.fsf@gmail.com \
    --to=frej.drejhammar@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haokexin@gmail.com \
    --cc=jyri.sarha@iki.fi \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mripard@kernel.org \
    --cc=sarha@kapsi.fi \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.