From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 08/27] bonding: remove bond_for_each_slave_reverse()
Date: Wed, 11 Sep 2013 01:53:14 +0000 (UTC) [thread overview]
Message-ID: <l0oiea$jo6$2@ger.gmane.org> (raw)
In-Reply-To: 1378846691-9717-9-git-send-email-vfalico@redhat.com
On Tue, 10 Sep 2013 at 20:57 GMT, Veaceslav Falico <vfalico@redhat.com> wrote:
> We only use it in rollback scenarios and can easily use the standart
> bond_for_each_dev() instead.
>
What you remove actually is bond_for_each_slave_continue_reverse()...
$subject needs to be fixed.
> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
> index c3dcc6b..46f6b40 100644
> --- a/drivers/net/bonding/bond_alb.c
> +++ b/drivers/net/bonding/bond_alb.c
> @@ -1246,9 +1246,9 @@ static int alb_handle_addr_collision_on_attach(struct bonding *bond, struct slav
> */
> static int alb_set_mac_address(struct bonding *bond, void *addr)
> {
> - char tmp_addr[ETH_ALEN];
> - struct slave *slave;
> + struct slave *slave, *rollback_slave;
> struct sockaddr sa;
> + char tmp_addr[ETH_ALEN];
Why are you moving tmp_addr[]?
next prev parent reply other threads:[~2013-09-11 1:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 20:57 [PATCH v2 net-next 00/27] bonding: use neighbours instead of own lists Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 01/27] net: add adj_list to save only neighbours Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 02/27] net: add RCU variant to search for netdev_adjacent link Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 03/27] net: uninline netdev neighbour functions Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 04/27] net: add netdev_adjacent->private and allow to use it Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 05/27] bonding: populate neighbour's private on enslave Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 06/27] bonding: modify bond_get_slave_by_dev() to use neighbours Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 07/27] net: add for_each iterators through neighbour lower link's private Veaceslav Falico
2013-09-11 1:46 ` Cong Wang
2013-09-11 5:37 ` Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 08/27] bonding: remove bond_for_each_slave_reverse() Veaceslav Falico
2013-09-11 1:53 ` Cong Wang [this message]
2013-09-11 5:39 ` Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 09/27] bonding: make bond_for_each_slave() use lower neighbour's private Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 10/27] bonding: use bond_for_each_slave() in bond_uninit() Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 11/27] bonding: rework bond_3ad_xmit_xor() to use bond_for_each_slave() only Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 12/27] bonding: rework rlb_next_rx_slave() to use bond_for_each_slave() Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 13/27] bonding: rework bond_find_best_slave() " Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 14/27] bonding: rework bond_ab_arp_probe() " Veaceslav Falico
2013-09-10 20:57 ` [PATCH v2 net-next 15/27] bonding: remove unused bond_for_each_slave_from() Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 16/27] bonding: add bond_has_slaves() and use it Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 17/27] bonding: convert bond_has_slaves() to use the neighbour list Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 18/27] net: add a possibility to get private from netdev_adjacent->list Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 19/27] bonding: convert first/last slave logic to use neighbours Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 20/27] bonding: remove bond_prev_slave() Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 21/27] net: add a function to get the next private Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 22/27] bonding: use neighbours for bond_next_slave() Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 23/27] bonding: remove slave lists Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 24/27] vlan: link the upper neighbour only after registering Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 25/27] vlan: unlink the upper neighbour before unregistering Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 26/27] net: expose the master link to sysfs, and remove it from bond Veaceslav Falico
2013-09-10 20:58 ` [PATCH v2 net-next 27/27] net: create sysfs symlinks for neighbour devices Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='l0oiea$jo6$2@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.