From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794999246; b=vhaYZeY0aDaJjOO45StPS1LMjULHuFs1fe9acidYDM4ij0yqVvqMTW/YqQli1yEFIksG U0eK6e2y7Uo4NoCe8FO0e5vLsfAYZdcE7U9sKWIPq9TInQrPCqIcg6Mw0hcF7a8NbJYay 21YFNAwtW3GbhI8Oq6/IUF7a/gcXSghlA51QEGOhPBh3mJHGjJtDMv/76LZYy0XkSSojL TPS2xCMHrV/7ziafqcH752m+DlBDbDDngls7MM3wTFkVfDIz7FWD//kPvm4BaPqGDX6xd +8in5cYMXq3TU0KoKfBD22v9EgvYIGm6RIkIfn912QFobSSJn1cdtzj2u1J7IcJ5gZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794999246; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=2d12lWVGBsaoMn/Enc4uD3O8Aj7O2S/+EaVF50C+EQ4=; b=kxoXC4PkWNKAHbY1oQ2Q3Aix01TImXjYOHT2DpBgVIZHCj6p4tSmWh+C5GESycVhY2yi Nm0nH/vaifnJEhLxPhVsGvWOdWL5oPwo36ouqyhWOK4Fc6NhPRwIZKCniMPL8LnfyH8ci HA+vlVeXs+/5TQOa+ZQ1ryJdwbp+SdWBpkpKlU4dB+yGjWNZev17Zu7A0AUskNP+mmGpX /L51LAwT+eKEUmI2XhU0ZU2km1URvByStZVQa7jwi2b5WdRYqySJAwhXrn5cM4uyO1uw5 b+KdJepD2Xn6XLObQPSjKqoy+1m1WU1L1oHPp28O97+3pkT3cYu2OCO2+OmVtH9S7nQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ASB9sl6E; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A4EC606A31C for ; Wed, 18 Nov 2026 10:54:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9A4EC606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ASB9sl6E DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=2d12lWVGBsaoMn/Enc4uD3O8Aj7O2S/+EaVF50C+EQ4=; b=ASB9sl6EOSdJIB1EGdzGn/PsUI tjmO5szAeJdZlM3+Q+1IxHT6bEQz7NGbHeDeXN/VaxTVXWPcEGKc4AfeQfzAuyTuxCIVTt7MpD5t/ XlSIvngr8SDDvOVk9p25Jn/Q/FYRGNish8CUgxxwlY5S/t2eXyRIV1e04CKzxeg55zOC/EKwYhBkO GGKPXSQczmZOV3gvlJe9BxKNc5Kdwfh74CEC8xAFFoZieOiti6wZ9MnWlrXi0cC/pRxJv6OdZvQ5k F+DEY3D2KFaFrIzZppTvcBQ5gdYd88NvoFprVbrXRsYK2qEsmfnrs9yIAcKEjRDQLi4S3L2LG/LU8 ffa/brvQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Sebastian Reichel Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de, Lee Jones , Heiko Stuebner Subject: Re: [PATCH v3 6/7] spi: rockchip: Move to pm_runtime_resume_and_get Date: Wed, 18 Nov 2026 11:54:02 +0100 Message-ID: In-Reply-To: References: <20261117235021.2013719-1-heiko@sntech.de> <20261117235021.2013719-7-heiko@sntech.de> X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Mittwoch, 18. November 2026, 02:53:32 Mitteleurop=C3=A4ische Normalzeit = schrieb Sebastian Reichel: > Hi, >=20 > On Wed, Nov 18, 2026 at 12:50:20AM +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner > >=20 > > Currently pm_runtime_get_sync() is used, which increments the usage > > count even if the resume was not successful. > >=20 > > Move to the more modern pm_runtime_resume_and_get() which handles the > > usage counter better. > >=20 > > Signed-off-by: Heiko Stuebner > > --- >=20 > This only makes sense when combined with error handling. Keeping > the use count increased makes more sense for the current code: >=20 > pm_runtime_get_sync(); // keep use count increased on failure > random_code(); > pm_runtime_put(); // always decrease the RPM use count >=20 > Meanwhile your new code would result in double decrease on error: darn, one should not go "eh, let's just use the same pm-runtime pattern, should be easy" ;-) . But I guess real error handling in those cases might actually desireable. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF2F0606A320 for ; Wed, 18 Nov 2026 10:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vKAjCWS+; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=ASB9sl6E DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=mDVdNmC56Bvw3I94mEdzX/NSW8LrS4qdbkRuU2ILT04=; b=vKAjCWS+6c3CsqULebJny97f8R MoXepmRm8r+wQUlXGKrcMR1fefbNSy6ERrefr0Z+pno/hkMhccAKhf1GiEXlebMx6FjfBKtoJuuwT t9ds4fagBNHh2fZ6A+EWrF8zp80G/S8XcaJjeHPxyD+/8M1I+mNbWjqHQc/zk9u3wJ0RwE59Bn9fo wna8g88uqXNu31tySM7/WNRhmscvrJw/V1uEp4t7BdYF/vL2q3/Pa2zCJO2p6ImR8myNI0p00kpi9 BVNJLDcJL32JGSPlehq/zqhS2VcAJkVpNO0clSoiZ/1lKRDlFnwZWpiOfi+0YGYvLQqECJmvClNIp sxpsyurA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTdIo-00000008dwm-32vx; Wed, 18 Nov 2026 10:54:10 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTdIl-00000008duy-3a5F; Wed, 18 Nov 2026 10:54:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=2d12lWVGBsaoMn/Enc4uD3O8Aj7O2S/+EaVF50C+EQ4=; b=ASB9sl6EOSdJIB1EGdzGn/PsUI tjmO5szAeJdZlM3+Q+1IxHT6bEQz7NGbHeDeXN/VaxTVXWPcEGKc4AfeQfzAuyTuxCIVTt7MpD5t/ XlSIvngr8SDDvOVk9p25Jn/Q/FYRGNish8CUgxxwlY5S/t2eXyRIV1e04CKzxeg55zOC/EKwYhBkO GGKPXSQczmZOV3gvlJe9BxKNc5Kdwfh74CEC8xAFFoZieOiti6wZ9MnWlrXi0cC/pRxJv6OdZvQ5k F+DEY3D2KFaFrIzZppTvcBQ5gdYd88NvoFprVbrXRsYK2qEsmfnrs9yIAcKEjRDQLi4S3L2LG/LU8 ffa/brvQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Sebastian Reichel Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de, Lee Jones , Heiko Stuebner Subject: Re: [PATCH v3 6/7] spi: rockchip: Move to pm_runtime_resume_and_get Date: Wed, 18 Nov 2026 11:54:02 +0100 Message-ID: In-Reply-To: References: <20261117235021.2013719-1-heiko@sntech.de> <20261117235021.2013719-7-heiko@sntech.de> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_025407_889988_8EC4A64D X-CRM114-Status: GOOD ( 15.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gTWl0dHdvY2gsIDE4LiBOb3ZlbWJlciAyMDI2LCAwMjo1MzozMiBNaXR0ZWxldXJvcMOkaXNj aGUgTm9ybWFsemVpdCBzY2hyaWViIFNlYmFzdGlhbiBSZWljaGVsOgo+IEhpLAo+IAo+IE9uIFdl ZCwgTm92IDE4LCAyMDI2IGF0IDEyOjUwOjIwQU0gKzAxMDAsIEhlaWtvIFN0dWVibmVyIHdyb3Rl Ogo+ID4gRnJvbTogSGVpa28gU3R1ZWJuZXIgPGhlaWtvLnN0dWVibmVyQGNoZXJyeS5kZT4KPiA+ IAo+ID4gQ3VycmVudGx5IHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBpcyB1c2VkLCB3aGljaCBpbmNy ZW1lbnRzIHRoZSB1c2FnZQo+ID4gY291bnQgZXZlbiBpZiB0aGUgcmVzdW1lIHdhcyBub3Qgc3Vj Y2Vzc2Z1bC4KPiA+IAo+ID4gTW92ZSB0byB0aGUgbW9yZSBtb2Rlcm4gcG1fcnVudGltZV9yZXN1 bWVfYW5kX2dldCgpIHdoaWNoIGhhbmRsZXMgdGhlCj4gPiB1c2FnZSBjb3VudGVyIGJldHRlci4K PiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSGVpa28gU3R1ZWJuZXIgPGhlaWtvLnN0dWVibmVyQGNo ZXJyeS5kZT4KPiA+IC0tLQo+IAo+IFRoaXMgb25seSBtYWtlcyBzZW5zZSB3aGVuIGNvbWJpbmVk IHdpdGggZXJyb3IgaGFuZGxpbmcuIEtlZXBpbmcKPiB0aGUgdXNlIGNvdW50IGluY3JlYXNlZCBt YWtlcyBtb3JlIHNlbnNlIGZvciB0aGUgY3VycmVudCBjb2RlOgo+IAo+IHBtX3J1bnRpbWVfZ2V0 X3N5bmMoKTsgLy8ga2VlcCB1c2UgY291bnQgaW5jcmVhc2VkIG9uIGZhaWx1cmUKPiByYW5kb21f Y29kZSgpOwo+IHBtX3J1bnRpbWVfcHV0KCk7IC8vIGFsd2F5cyBkZWNyZWFzZSB0aGUgUlBNIHVz ZSBjb3VudAo+IAo+IE1lYW53aGlsZSB5b3VyIG5ldyBjb2RlIHdvdWxkIHJlc3VsdCBpbiBkb3Vi bGUgZGVjcmVhc2Ugb24gZXJyb3I6CgpkYXJuLCBvbmUgc2hvdWxkIG5vdCBnbyAiZWgsIGxldCdz IGp1c3QgdXNlIHRoZSBzYW1lIHBtLXJ1bnRpbWUgcGF0dGVybiwKc2hvdWxkIGJlIGVhc3kiIDst KSAuCgpCdXQgSSBndWVzcyByZWFsIGVycm9yIGhhbmRsaW5nIGluIHRob3NlIGNhc2VzIG1pZ2h0 IGFjdHVhbGx5IGRlc2lyZWFibGUuCgoKSGVpa28KCgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51 eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK