From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v2 1/1] recipes-graphics/lxdm: add missing automake file, update build config
Date: Mon, 17 Mar 2014 10:01:26 +0100 [thread overview]
Message-ID: <lg6dgr$5h8$1@ger.gmane.org> (raw)
In-Reply-To: <1395014647-18396-1-git-send-email-stephen.arnold42@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stephen Arnold schreef op 17-03-14 01:04:
> From: "Stephen Arnold" <stephen.arnold42@gmail.com>
>
> PATCH recipes-graphics/lxdm:
>
> - add missing depends and inherit pkgconfig for autogen/configure -
> silence confgure warnings and update configure options - provide missing
> input file for automake
>
> Built and tested on master branches using meta-raspberrypi and
> meta-alt-destop-extras.
>
> Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com>
>
> --- meta-oe/recipes-graphics/lxdm/lxdm_git.bb | 13 +++++++++++-- 1 file
> changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb
> b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb index c12eddf..6ef014f
> 100644 --- a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb +++
> b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb @@ -16,18 +16,27 @@ SRCREV =
> "07fb151a99ef99318b71f3de0afbba977b1e6267" PV = "0.5.0+git${SRCPV}" PE =
> "1"
>
> -DEPENDS = "cairo dbus gdk-pixbuf glib-2.0 gtk+ virtual/libx11 libxcb
> pango" +DEPENDS = "virtual/libintl intltool-native cairo dbus gdk-pixbuf
> glib-2.0 gtk+ virtual/libx11 libxcb pango iso-codes" DEPENDS +=
> "${@base_contains("DISTRO_FEATURES", "systemd", "", "consolekit", d)}"
>
> # combine oe-core way with angstrom DISTRO_TYPE DISTRO_TYPE ?=
> "${@base_contains("IMAGE_FEATURES", "debug-tweaks", "debug", "",d)}"
>
> -inherit autotools gettext systemd +inherit autotools pkgconfig gettext
> systemd
>
> S = "${WORKDIR}/git"
>
> +CFLAGS_append = " -fno-builtin-fork -fno-builtin-memset
> -fno-builtin-strstr "
Why is this needed?
> + +EXTRA_OECONF += "--enable-gtk3=no --enable-password=yes --with-x
> -with-xconn=xcb" EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES',
> 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/
> --disable-consolekit', '--without-systemdsystemunitdir', d)}"
Please merge those 2 into a single EXTRA_OECONF
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFTJrnmMkyGM64RGpERAjj6AKCjLjwuMeDHNZEY22fPsNKnf9ZijQCgl0Gj
RVZBFHTR0QsI2gXGzLy8+lg=
=rUX5
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2014-03-17 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 0:04 [meta-oe][PATCH v2 1/1] recipes-graphics/lxdm: add missing automake file, update build config Stephen Arnold
2014-03-17 9:01 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='lg6dgr$5h8$1@ger.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.