From: Florian Weimer <fweimer@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, patches@lists.linux.dev,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
Josef Bacik <josef@toxicpanda.com>,
Aleksa Sarai <cyphar@cyphar.com>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
David Howells <dhowells@redhat.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v3] uapi/linux/fcntl: remove AT_RENAME* macros
Date: Fri, 05 Sep 2025 09:19:33 +0200 [thread overview]
Message-ID: <lhu7bydv01m.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <b35f0ff7-8ffb-400f-b537-d15e83319808@infradead.org> (Randy Dunlap's message of "Thu, 4 Sep 2025 14:52:34 -0700")
* Randy Dunlap:
> On 9/4/25 11:49 AM, Florian Weimer wrote:
>> * Amir Goldstein:
>>
>>> I find this end result a bit odd, but I don't want to suggest another variant
>>> I already proposed one in v2 review [1] that maybe you did not like.
>>> It's fine.
>>> I'll let Aleksa and Christian chime in to decide on if and how they want this
>>> comment to look or if we should just delete these definitions and be done with
>>> this episode.
>>
>> We should fix the definition in glibc to be identical token-wise to the
>> kernel's.
>
> That's probably a good suggestion...
> while I tried the reverse of that and Amir opposed.
It's certainly odd that the kernel uses different token sequences for
defining AT_RENAME_* and RENAME_*. But it's probably too late to fix
that.
Here's the glibc patch:
[PATCH] libio: Define AT_RENAME_* with the same tokens as Linux
<https://inbox.sourceware.org/libc-alpha/lhubjnpv03o.fsf@oldenburg.str.redhat.com/T/#u>
Thanks,
Florian
next prev parent reply other threads:[~2025-09-05 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:22 [PATCH v3] uapi/linux/fcntl: remove AT_RENAME* macros Randy Dunlap
2025-09-04 18:17 ` Amir Goldstein
2025-09-04 18:49 ` Florian Weimer
2025-09-04 21:52 ` Randy Dunlap
2025-09-05 7:19 ` Florian Weimer [this message]
2025-09-05 7:36 ` Randy Dunlap
2025-09-04 21:51 ` Randy Dunlap
2025-09-05 5:11 ` Aleksa Sarai
2025-09-05 9:17 ` Amir Goldstein
2025-09-05 9:41 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lhu7bydv01m.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=rdunlap@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.