[meta-oe][PATCH] lvm2.inc: EXTRA_OECONF is been overwrited.

[meta-oe][PATCH] lvm2.inc: EXTRA_OECONF is been overwrited.

[Yao Xinpan]

EXTRA_OECONF has been assigned before ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’.
collaps the 2 lines into a single EXTRA_OECONF.

Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
---
 meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
index c6a9ec0..5f77fe6 100644
--- a/meta-oe/recipes-support/lvm2/lvm2.inc
+++ b/meta-oe/recipes-support/lvm2/lvm2.inc
@@ -28,6 +28,7 @@ EXTRA_OECONF = "--with-user= \
                 --enable-pkgconfig \
                 --enable-dmeventd \
                 --with-udev-prefix= \
+                --with-usrlibdir=${libdir} \
 "
 
 PACKAGECONFIG += "${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
@@ -47,4 +48,3 @@ FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
 FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
 
 RDEPENDS_${PN} = "bash"
-EXTRA_OECONF = "--with-usrlibdir=${libdir}"
-- 
1.8.4.2

Re: [meta-oe][PATCH] lvm2.inc: EXTRA_OECONF is been overwrited.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yao Xinpan schreef op 06-06-14 12:18:
> EXTRA_OECONF has been assigned before ‘EXTRA_OECONF =
> "--with-usrlibdir=${libdir}"’. collaps the 2 lines into a single
> EXTRA_OECONF.

Minor nit: the commit summary could be written as

'lvm2: don't overrwrite EXTRA_OECONF

> 
> Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com> --- 
> meta-oe/recipes-support/lvm2/lvm2.inc | 2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc
> b/meta-oe/recipes-support/lvm2/lvm2.inc index c6a9ec0..5f77fe6 100644 ---
> a/meta-oe/recipes-support/lvm2/lvm2.inc +++
> b/meta-oe/recipes-support/lvm2/lvm2.inc @@ -28,6 +28,7 @@ EXTRA_OECONF =
> "--with-user= \ --enable-pkgconfig \ --enable-dmeventd \ 
> --with-udev-prefix= \ +                --with-usrlibdir=${libdir} \ "
> 
> PACKAGECONFIG += "${@base_contains('DISTRO_FEATURES', 'selinux',
> 'selinux', '', d)}" @@ -47,4 +48,3 @@ FILES_${PN} +=
> "${libdir}/device-mapper/*.so ${base_libdir}/udev" FILES_${PN}-dbg +=
> "${libdir}/device-mapper/.debug"
> 
> RDEPENDS_${PN} = "bash" -EXTRA_OECONF = "--with-usrlibdir=${libdir}"

The patch itself looks good.

regards,

Koen


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTkZ3HMkyGM64RGpERAjfhAJ4s1w90KTzPYajHI6Joe7Cww8VF/ACfdgO5
3PqFp52Qkkg4/RO/7W7PCys=
=RBeY
-----END PGP SIGNATURE-----

答复: [meta-oe][PATCH] lvm2.inc: EXTRA_OECONF is been overwrited.

[yaoxp]

Thank you

I will send a new patch

> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Yao Xinpan schreef op 06-06-14 12:18:
> > EXTRA_OECONF has been assigned before ‘EXTRA_OECONF =
> > "--with-usrlibdir=${libdir}"’. collaps the 2 lines into a single
> > EXTRA_OECONF.
> 
> Minor nit: the commit summary could be written as
> 
> 'lvm2: don't overrwrite EXTRA_OECONF
> 
> >
> > Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com> ---
> > meta-oe/recipes-support/lvm2/lvm2.inc | 2 +- 1 file changed, 1
> > insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc
> > b/meta-oe/recipes-support/lvm2/lvm2.inc index c6a9ec0..5f77fe6 100644
> > --- a/meta-oe/recipes-support/lvm2/lvm2.inc +++
> > b/meta-oe/recipes-support/lvm2/lvm2.inc @@ -28,6 +28,7 @@
> EXTRA_OECONF
> > = "--with-user= \ --enable-pkgconfig \ --enable-dmeventd \
> > --with-udev-prefix= \ +                --with-usrlibdir=${libdir} \ "
> >
> > PACKAGECONFIG += "${@base_contains('DISTRO_FEATURES', 'selinux',
> > 'selinux', '', d)}" @@ -47,4 +48,3 @@ FILES_${PN} +=
> > "${libdir}/device-mapper/*.so ${base_libdir}/udev" FILES_${PN}-dbg +=
> > "${libdir}/device-mapper/.debug"
> >
> > RDEPENDS_${PN} = "bash" -EXTRA_OECONF = "--with-usrlibdir=${libdir}"
> 
> The patch itself looks good.
> 
> regards,
> 
> Koen
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> 
> iD8DBQFTkZ3HMkyGM64RGpERAjfhAJ4s1w90KTzPYajHI6Joe7Cww8VF/ACfdgO
> 5
> 3PqFp52Qkkg4/RO/7W7PCys=
> =RBeY
> -----END PGP SIGNATURE-----
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel