From: malc <malc@pulsesoft.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Audio output for CS4231, patch/RFC
Date: Sun, 24 Sep 2006 03:22:49 +0000 (UTC) [thread overview]
Message-ID: <loom.20060924T051617-456@post.gmane.org> (raw)
In-Reply-To: BAY104-F306AC8656BB13CE2C23A8FF260@phx.gbl
Blue Swirl <blueswir1 <at> hotmail.com> writes:
>
> Hi,
>
> This patch hooks CS4231 to the audio subsystem. It's not ready for applying,
> though I can already make some noise. Any comments?
After having a cursory look at it only one thing really caught my attention:
in the audio callback you set s->audio_free to the provided value, but then
in you never use it. If i'm reading everything correctly this would lead to
reading N bytes from DMA in write_audio, succeeding in writing only M bytes
(where M < N) to the audio subsystem and loosing N-M bytes forever. Basically
you should never attempt to do volatile reads of more than audio_free bytes.
SB16 operates in similar fashion.
next prev parent reply other threads:[~2006-09-24 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 16:13 [Qemu-devel] Audio output for CS4231, patch/RFC Blue Swirl
2006-09-23 17:52 ` [Qemu-devel] " Fabrice Bellard
2006-09-23 19:14 ` Blue Swirl
2006-09-24 3:22 ` malc [this message]
2006-09-24 6:23 ` Blue Swirl
2006-09-24 10:39 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20060924T051617-456@post.gmane.org \
--to=malc@pulsesoft.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.