Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

[Nolan <nolan@sigbus.net>]

Anthony Liguori <aliguori <at> us.ibm.com> writes:
>  
> This is needed for VMware VGA to work properly under KVM.
> 
> Signed-off-by: Anthony Liguori <aliguori <at> us.ibm.com>
> ---
>  hw/vmware_vga.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
> index bb17698..246011b 100644
> --- a/hw/vmware_vga.c
> +++ b/hw/vmware_vga.c
> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int
region_num,
>  #endif
>      cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>                      iomemtype);
> +
> +    s->vga.map_addr = addr;
> +    s->vga.map_end = addr + s->vga.vram_size;
> +    vga_dirty_log_start(&s->vga);
>  }
> 
>  void pci_vmsvga_init(PCIBus *bus)

Using the MMU to track writes to VRAM should only be needed when the FIFO is
disabled.  When the FIFO is enabled (SVGA_REG_CONFIG_DONE = 1), the guest will
notify the host via the FIFO when it has written to a region of VRAM directly,
using the SVGA_CMD_UPDATE FIFO command.

Unless I'm confused, this change appears to use the MMU to track VRAM updates
unconditionally.