From: Michael Leal <michaelleal8@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH v3 00/19] new git check-ignore sub-command
Date: Thu, 27 Dec 2012 05:15:55 +0000 (UTC) [thread overview]
Message-ID: <loom.20121227T061300-665@post.gmane.org> (raw)
In-Reply-To: 1356575558-2674-1-git-send-email-git@adamspiers.org
Adam Spiers <git <at>
adamspiers.org> writes:
>
> This v3 re-roll of my check-
ignore series is a reasonably
substantial
> revamp over v2, and applies on
top of Junio's current
> nd/attr-match-optim-more
branch (82dce998c202).
>
> All feedback and patches from
the v2 series has been
incorporated, and
> several other improvements
too, including:
>
> - composite exclude_lists
have been split up into
> exclude_list_groups each
containing one exclude_list per
source
>
> - smaller commits for easier
review
>
> - minor memory leaks have
been fixed and verified via
valgrind
>
> - t0007-ignores.sh has been
renumbered to t0008-ignores.sh
to avoid
> a conflict with t0007-git-
var.sh
>
> - improvements to
documentation and comments
>
> For reference, the v2 series
was announced here:
>
> http://thread.gmane.org/
gmane.comp.version-
control.git/204661/
focus=206074
>
> All tests pass except for t91*,
since there seems to be some
> pre-existing breakage in
82dce998c202 relating to git-
svn.
>
> Adam Spiers (19):
> api-directory-listing.txt:
update to match code
> Improve documentation and
comments regarding directory
traversal API
> dir.c: rename cryptic 'which'
variable to more consistent
name
> dir.c: rename path_excluded()
to is_path_excluded()
> dir.c: rename
excluded_from_list() to
is_excluded_from_list()
> dir.c: rename excluded() to
is_excluded()
> dir.c: refactor
is_excluded_from_list()
> dir.c: refactor is_excluded()
> dir.c: refactor
is_path_excluded()
> dir.c: rename free_excludes()
to clear_exclude_list()
> dir.c: use a single struct
exclude_list per source of
excludes
> dir.c: keep track of where
patterns came from
> dir.c: provide clear_directory()
for reclaiming dir_struct memory
> add.c: refactor treat_gitlinks()
> add.c: remove unused
argument from
validate_pathspec()
> pathspec.c: move reusable
code from builtin/add.c
> pathspec.c: extract new
validate_path() for reuse
> setup.c: document
get_pathspec()
> Add git-check-ignore sub-
command
>
> .gitignore
| 1 +
> Documentation/git-check-
ignore.txt | 89 ++++
> Documentation/gitignore.txt
| 6 +-
> Documentation/technical/api-
directory-listing.txt | 35 +-
> Makefile
| 3 +
> attr.c |
2 +-
> builtin.h
| 1 +
> builtin/add.c
| 84 +--
> builtin/check-ignore.c
| 170 +++++++
> builtin/clean.c
| 3 +-
> builtin/ls-files.c
| 11 +-
> command-list.txt
| 1 +
> contrib/completion/git-
completion.bash | 1 +
> dir.c |
243 +++++++--
> dir.h |
87 +++-
> git.c |
1 +
> pathspec.c
| 107 ++++
> pathspec.h
| 6 +
> setup.c
| 15 +
> t/t0008-ignores.sh
| 595
++++++++++++++++++++++
> unpack-trees.c
| 14 +-
> 21 files changed, 1305
insertions(+), 170 deletions(-)
> create mode 100644
Documentation/git-check-
ignore.txt
> create mode 100644 builtin/
check-ignore.c
> create mode 100644
pathspec.c
> create mode 100644
pathspec.h
> create mode 100755 t/t0008-
ignores.sh
>
next prev parent reply other threads:[~2012-12-27 5:35 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 2:32 [PATCH v3 00/19] new git check-ignore sub-command Adam Spiers
2012-12-27 2:32 ` [PATCH v3 01/19] api-directory-listing.txt: update to match code Adam Spiers
2012-12-27 2:32 ` [PATCH v3 02/19] Improve documentation and comments regarding directory traversal API Adam Spiers
2013-01-01 20:52 ` Junio C Hamano
2013-01-02 12:54 ` Adam Spiers
2013-01-06 12:02 ` Adam Spiers
2012-12-27 2:32 ` [PATCH v3 03/19] dir.c: rename cryptic 'which' variable to more consistent name Adam Spiers
2012-12-27 2:32 ` [PATCH v3 04/19] dir.c: rename path_excluded() to is_path_excluded() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 05/19] dir.c: rename excluded_from_list() to is_excluded_from_list() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 06/19] dir.c: rename excluded() to is_excluded() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 07/19] dir.c: refactor is_excluded_from_list() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 08/19] dir.c: refactor is_excluded() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 09/19] dir.c: refactor is_path_excluded() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 10/19] dir.c: rename free_excludes() to clear_exclude_list() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes Adam Spiers
2013-01-04 21:03 ` Junio C Hamano
2013-01-05 7:54 ` Junio C Hamano
2013-01-06 15:27 ` Adam Spiers
2013-01-06 15:35 ` [PATCH] api-allocation-growing.txt: encourage better variable naming Adam Spiers
2013-01-06 20:29 ` Junio C Hamano
2013-01-06 20:52 ` Adam Spiers
2013-01-06 20:58 ` Junio C Hamano
2013-01-06 15:20 ` [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes Adam Spiers
2013-01-06 20:25 ` Junio C Hamano
2013-01-06 22:53 ` Adam Spiers
2013-01-06 23:17 ` Adam Spiers
2013-01-06 23:19 ` Junio C Hamano
2012-12-27 2:32 ` [PATCH v3 12/19] dir.c: keep track of where patterns came from Adam Spiers
2012-12-27 2:32 ` [PATCH v3 13/19] dir.c: provide clear_directory() for reclaiming dir_struct memory Adam Spiers
2012-12-27 2:32 ` [PATCH v3 14/19] add.c: refactor treat_gitlinks() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 15/19] add.c: remove unused argument from validate_pathspec() Adam Spiers
2012-12-27 2:32 ` [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c Adam Spiers
2012-12-28 20:32 ` Junio C Hamano
2012-12-28 20:45 ` Adam Spiers
2012-12-29 0:40 ` Adam Spiers
2012-12-28 20:48 ` Junio C Hamano
2012-12-28 21:15 ` Adam Spiers
2012-12-27 2:32 ` [PATCH v3 17/19] pathspec.c: extract new validate_path() for reuse Adam Spiers
2012-12-28 20:44 ` Junio C Hamano
2012-12-28 21:08 ` Adam Spiers
2012-12-27 2:32 ` [PATCH v3 18/19] setup.c: document get_pathspec() Adam Spiers
2012-12-28 20:36 ` Junio C Hamano
2012-12-28 20:40 ` Adam Spiers
2012-12-29 0:52 ` Adam Spiers
2012-12-29 1:36 ` Junio C Hamano
2012-12-27 2:32 ` [PATCH v3 19/19] Add git-check-ignore sub-command Adam Spiers
2012-12-28 21:21 ` Junio C Hamano
2012-12-29 1:23 ` Adam Spiers
2012-12-29 3:32 ` Adam Spiers
2012-12-27 5:15 ` Michael Leal [this message]
2012-12-28 18:50 ` [PATCH v3 00/19] new git check-ignore sub-command Junio C Hamano
2012-12-28 19:39 ` Adam Spiers
2012-12-28 20:15 ` Antoine Pelisse
2012-12-28 21:31 ` Junio C Hamano
2012-12-28 21:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20121227T061300-665@post.gmane.org \
--to=michaelleal8@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.