All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: xen-devel@lists.xensource.com
Subject: Re: [RFC] CCing MAINTAINERS on patches by default?
Date: Tue, 11 Jun 2013 18:23:12 +0000 (UTC)	[thread overview]
Message-ID: <loom.20130611T201723-757@post.gmane.org> (raw)
In-Reply-To: 1363167630.32410.98.camel@zakaz.uk.xensource.com

Ian Campbell <Ian.Campbell <at> citrix.com> writes:
> On Tue, 2013-03-12 at 20:35 +0000, Konrad Rzeszutek Wilk wrote:
> > On Tue, Mar 12, 2013 at 05:07:42PM +0000, Tim Deegan wrote:
> > > At 17:00 +0000 on 12 Mar (1363107618), Ian Campbell wrote:
> > > > With the numbers of patches flying around it can be a bit hard for a
> > > > maintainer to spot patches which (s)he is expected to comment on / deal
> > > > with, especially now that we have a larger number of maintainers of
> > > > varying subsystems etc.
> > > > 
> > > > I think it might be time to start asking patch submitters to CC the
> > > > maintainers of the code they are touching, based on the MAINTAINERS
> > > > file.
> > > > 
> > > > If people (specifically maintainers) agree with this change then we can
> > > > start by updating the "Submitting Patches" docs on the wiki etc and
> > > > gently start requesting submitters to add the CCs.
> > > 
> > > Fine by me; I usually work from my xen-devel inbox but I don't object to
> > > being Cc'd directly.
> > > 
> > > Can we provide git/hg runes to add Cc:s automatically?
> > 
> > That would be neat. Linux uses scripts/get_maintainers.pl to fetch from
> > the MAINTAINERS file the names of folks. That could be imported in?
> 
> Linux's get_maintainers.pl is way too aggressive about who it defaults
> to CCing (basically the world and his dog). How about we go with asking
> for manual CCs for now and we can revisit tooling (e.g. tweaking the
> get_maintainer's defaults) once we've got a feel for what works for us.

linux's get_maintainers by default no longer cc's the world.

It looks to see if a file has a maintainer, and if it does, it lists
only that person (and any other higher-level by path maintainer).

If a file does not have a maintainer, it tries to use git or hg
history sign-offs.

These behaviours can be controlled by adding command line options.

--git             (always use git history <default:n>)
--git-fallback    (use git history when there's no maintainer <default:y>)

So using get_maintainer --nogit --nogit-fallback might do what you want.

  reply	other threads:[~2013-06-11 18:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 17:00 [RFC] CCing MAINTAINERS on patches by default? Ian Campbell
2013-03-12 17:07 ` Tim Deegan
2013-03-12 17:29   ` Ian Campbell
2013-03-12 20:35   ` Konrad Rzeszutek Wilk
2013-03-13  9:40     ` Ian Campbell
2013-06-11 18:23       ` Joe Perches [this message]
2013-03-12 17:16 ` Keir Fraser
2013-03-12 18:03 ` Ian Jackson
2013-03-13  8:17 ` Jan Beulich
2013-03-13  9:40   ` Ian Campbell
2013-03-15 13:38 ` Please CC MAINTAINERS on patches by default Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20130611T201723-757@post.gmane.org \
    --to=joe@perches.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.