From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joakim Plate <elupus@ecce.se>
Subject: Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks
Date: Fri, 13 Sep 2013 16:10:24 +0000 (UTC)
Message-ID: <loom.20130913T180539-921@post.gmane.org>
References: <1378493845-476-1-git-send-email-damien.lespiau@intel.com>
	<1378493845-476-8-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from plane.gmane.org (plane.gmane.org [80.91.229.3])
	by gabe.freedesktop.org (Postfix) with ESMTP id 87415E825D
	for <dri-devel@lists.freedesktop.org>;
	Fri, 13 Sep 2013 09:11:08 -0700 (PDT)
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <sf-dri-devel@m.gmane.org>) id 1VKVxS-00021k-0j
	for dri-devel@lists.freedesktop.org; Fri, 13 Sep 2013 18:10:58 +0200
Received: from mail.qrtech.se ([80.252.216.35])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <dri-devel@lists.freedesktop.org>; Fri, 13 Sep 2013 18:10:58 +0200
Received: from elupus by mail.qrtech.se with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <dri-devel@lists.freedesktop.org>; Fri, 13 Sep 2013 18:10:58 +0200
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Damien Lespiau <damien.lespiau <at> intel.com> writes:

> +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = {
> +	{ 1920, 1080, 24, 0,
> +	  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING 
},
> +	{ 1920, 1080, 50, DRM_MODE_FLAG_INTERLACE,
> +	  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF },
> +	{ 1920, 1080, 60, DRM_MODE_FLAG_INTERLACE,
> +	  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF },
> +	{ 1280, 720,  50, 0,
> +	  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING 
},
> +	{ 1280, 720,  60, 0,
> +	  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING }
> +};


I may be missing something here... But..

The frame packed modes are much higher in pixels than this and include frame 
packing.
1080*2+45=2050
720*2+30=1470

Unless you intend to hide the left/right split in mesa or other place, we 
need to get the ability to render to both fields somehow.

Either as the full 2050 pixels high or at 1080*2 and the driver adds the 
blanking.

Also, some logic aught to indicate pixel aspect ratio for the modes since 
they are non square for the half res modes.

/Joakim