All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ari Pollak <ari@debian.org>
To: git@vger.kernel.org
Subject: Re: Bug? diff.submodule=log adds text to commit -v message
Date: Mon, 11 Nov 2013 20:48:18 +0000 (UTC)	[thread overview]
Message-ID: <loom.20131111T214646-550@post.gmane.org> (raw)
In-Reply-To: 528140F5.6090700@web.de

Jens Lehmann writes:
> And after adding a modified file the log message also shows the diff of
> that file (and without leading "# "s too), so I doubt that diffs aren't
> normally included in the commit message with -v. What am I missing?

Ah, it is true that -v normally does not prefix the diffs with #, but there 
must be some filter in place after I save & quit my editor when a normal file 
diff is present, since that does not get included in the final commit 
message. But the submodule log does get included, which does not seem 
intentional.

Cheers,
Ari

  reply	other threads:[~2013-11-11 20:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10 21:49 Bug? diff.submodule=log adds text to commit -v message Ari Pollak
2013-11-11 20:41 ` Jens Lehmann
2013-11-11 20:48   ` Ari Pollak [this message]
2013-11-11 21:29     ` Jens Lehmann
2013-11-11 21:34       ` Jens Lehmann
2013-11-11 23:24       ` Jeff King
2013-11-12  7:46       ` Johannes Sixt
2013-11-12 22:17         ` Jens Lehmann
2013-11-12 22:20           ` Junio C Hamano
2013-11-13 18:37             ` Jens Lehmann
2013-11-13 20:04               ` Junio C Hamano
2013-11-16 22:52                 ` [RFC PATCH] commit -v: strip diffs and submodule shortlogs from the commit message Jens Lehmann
2013-11-17  0:22                   ` Eric Sunshine
2013-11-17  8:53                     ` Jeff King
2013-11-17  9:09                   ` Jeff King
2013-11-17 12:20                     ` Jens Lehmann
2013-11-18 16:01                     ` Junio C Hamano
2013-11-19 18:47                       ` [PATCH v2 ] " Jens Lehmann
2013-11-19 19:07                         ` Junio C Hamano
2013-11-19 19:31                         ` Junio C Hamano
2013-11-19 19:42                           ` Junio C Hamano
2013-11-19 20:34                         ` Junio C Hamano
2013-11-19 21:01                           ` Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20131111T214646-550@post.gmane.org \
    --to=ari@debian.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.