All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/6] scsi: clean up S/G table freeing
Date: Tue, 18 Nov 2014 18:14:30 +0000 (UTC)	[thread overview]
Message-ID: <loom.20141118T190348-558@post.gmane.org> (raw)
In-Reply-To: 1415259630-20784-4-git-send-email-hch@lst.de

Christoph Hellwig <hch <at> lst.de> writes:
> -static void scsi_release_buffers(struct scsi_cmnd *cmd)
> -{
> -	if (cmd->sdb.table.nents)
> -		scsi_free_sgtable(&cmd->sdb, false);
> -
> -	memset(&cmd->sdb, 0, sizeof(cmd->sdb));
> -
> -	if (scsi_prot_sg_count(cmd))
> -		scsi_free_sgtable(cmd->prot_sdb, false);
> -}

Hello Christoph,

Since I'm traveling I'm using a laptop with a small screen so I might be
missing some context information. What is not clear to me about this patch
is whether it changes a scsi_free_sgtable(cmd->prot_sdb, false) call into a
scsi_free_sgtable(cmd->prot_sdb, true) call for the non-mq path ?

Thanks,

Bart.


  parent reply	other threads:[~2014-11-18 18:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  7:40 I/O path cleanup V2 Christoph Hellwig
2014-11-06  7:40 ` [PATCH 1/6] scsi: don't use scsi_next_command in scsi_reset_provider Christoph Hellwig
2014-11-06  8:18   ` Hannes Reinecke
2014-11-06  7:40 ` [PATCH 2/6] scsi: remove scsi_next_command Christoph Hellwig
2014-11-06  8:21   ` Hannes Reinecke
2014-11-06 15:34     ` Christoph Hellwig
2014-11-11 16:37       ` Christoph Hellwig
2014-11-11 19:02         ` Hannes Reinecke
2014-11-06  7:40 ` [PATCH 3/6] scsi: clean up S/G table freeing Christoph Hellwig
2014-11-06  8:23   ` Hannes Reinecke
2014-11-18 18:14   ` Bart Van Assche [this message]
2014-11-20  8:16     ` Christoph Hellwig
2014-11-06  7:40 ` [PATCH 4/6] scsi: stop passing a gfp_mask argument down the command setup path Christoph Hellwig
2014-11-06  8:24   ` Hannes Reinecke
2014-11-06  7:40 ` [PATCH 5/6] scsi: move scsi_dispatch_cmd to scsi_lib.c Christoph Hellwig
2014-11-06  8:25   ` Hannes Reinecke
2014-11-06  7:40 ` [PATCH 6/6] scsi: move more requeue handling into scsi_requeue_command Christoph Hellwig
2014-11-06  8:26   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20141118T190348-558@post.gmane.org \
    --to=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.