Re: [meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Yang schreef op 09-07-14 12:21:
> 
> 
> On 07/09/2014 05:55 PM, Martin Jansa wrote:
>> On Tue, Jul 08, 2014 at 11:18:47PM -0700, Robert Yang wrote:
>>> The fftw, fftwf and fftwl provide the same files (different
>>> contents), we should only build one of them, otherwise there would be
>>> warning
>>> 
>>> WARNING: The recipe fftw is trying to install files into a shared
>>> area when those files already exist. Those files and their manifest
>>> location are: sysroots/qemux86-64/usr/include/fftw3.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3.h Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3q.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3.f Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3l.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot Please verify which
>>> package should provide the above files.
>>> 
>>> and maybe errors (race issue):
>>> 
>>> The recipe imagemagick.do_compiler error: fourier.c:69:19: fatal
>>> error: fftw3.h: No such file or directory #include <fftw3.h>
>>> 
>>> This is because imagemagick.do_configure depends on
>>> fftw.populate_sysroot, but the files installed by
>>> fftw.populate_sysroot, maybe removed by fftwl or fftwf when they
>>> rebuild.
>>> 
>>> Only build fftw in the world will fix the problem.
>> 
>> But it doesn't fix the problem for people who are really building
>> fftwl and fftw. If there is someone with this use-case can he send
>> patch moving common parts to separate recipe used by all 3 or just
>> rename/move files to have unique name?
>> 
>> Or if they aren't needed at the same time, lets convert fftwl and
>> fftwf to PACKAGECONFIG options in fftw.
> 
> Yes, I think that PACKAGECONFIG is a good idea, will send patches
> tomorrow if no objections.

The original idea of the different packages was that you could have all the
libraries in the binary feeds since they are needed. With packageconfig that
becomes virtually impossible.
I don't have a suggestion to improve the current situation, though :(

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTvmG+MkyGM64RGpERAu1zAJsGXdlezcHjV4JFjhTj9zeSaJ271ACdERQE
Xye89UlN8wZ3HEmV0fNGYMQ=
=iZI9
-----END PGP SIGNATURE-----