From: Christophe de Dinechin <dinechin@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
philmd@redhat.com
Subject: Re: [PATCH v5 05/10] ccid: build smartcard as module
Date: Wed, 22 Jul 2020 10:08:20 +0200 [thread overview]
Message-ID: <lywo2wgeff.fsf@redhat.com> (raw)
In-Reply-To: <20200721143305.nsxtsjg6kj57kqj4@sirius.home.kraxel.org>
On 2020-07-21 at 16:33 CEST, Gerd Hoffmann wrote...
>> > ifeq ($(CONFIG_USB_SMARTCARD),y)
>> > common-obj-y += dev-smartcard-reader.o
>>
>> I'm curious why you don't use something like:
>>
>> common-obj-$(CONFIG_USB_SMARTCARD)
>>
>> Do we want to be able to configure individual elements as modules?
>> Or is the intent to force as module things that are marked as 'y'?
>
> qemu kconfig miniconf handles bool only, not tristate.
Ah, I guess that right, I had a small "fix" for part of that in a recent
RFC, but you don't have it. OK.
>
> So, yes, for now we can do only "all modules" or "no modules" but
> nothing inbetween.
>
> take care,
> Gerd
--
Cheers,
Christophe de Dinechin (IRC c3d)
next prev parent reply other threads:[~2020-07-22 8:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:10 [PATCH v5 00/10] build some devices as modules Gerd Hoffmann
2020-06-24 13:10 ` [PATCH v5 01/10] module: qom module support Gerd Hoffmann
2020-07-20 14:16 ` Christophe de Dinechin
2020-07-21 14:16 ` Gerd Hoffmann
2022-09-05 9:17 ` Claudio Fontana
2022-09-05 14:21 ` Philippe Mathieu-Daudé via
2020-06-24 13:10 ` [PATCH v5 02/10] object: " Gerd Hoffmann
2020-07-20 14:20 ` Christophe de Dinechin
2020-07-21 14:26 ` Gerd Hoffmann
2020-07-21 14:35 ` Daniel P. Berrangé
2020-07-22 8:06 ` Christophe de Dinechin
2020-07-22 11:07 ` Gerd Hoffmann
2020-06-24 13:10 ` [PATCH v5 03/10] qdev: device " Gerd Hoffmann
2020-07-20 14:25 ` Christophe de Dinechin
2020-07-21 14:27 ` Gerd Hoffmann
2020-07-22 8:05 ` Christophe de Dinechin
2020-07-22 11:05 ` Gerd Hoffmann
2020-07-22 14:39 ` Christophe de Dinechin
2020-06-24 13:10 ` [PATCH v5 04/10] build: fix device module builds Gerd Hoffmann
2020-07-20 14:00 ` Christophe de Dinechin
2020-07-21 14:30 ` Gerd Hoffmann
2020-06-24 13:10 ` [PATCH v5 05/10] ccid: build smartcard as module Gerd Hoffmann
2020-07-20 14:30 ` Christophe de Dinechin
2020-07-21 14:33 ` Gerd Hoffmann
2020-07-22 8:08 ` Christophe de Dinechin [this message]
2020-06-24 13:10 ` [PATCH v5 06/10] usb: build usb-redir " Gerd Hoffmann
2020-07-20 14:43 ` Christophe de Dinechin
2020-06-24 13:10 ` [PATCH v5 07/10] vga: build qxl " Gerd Hoffmann
2020-07-20 15:01 ` Christophe de Dinechin
2020-06-24 13:10 ` [PATCH v5 08/10] vga: build virtio-gpu only once Gerd Hoffmann
2020-06-24 13:10 ` [PATCH v5 09/10] vga: build virtio-gpu as module Gerd Hoffmann
2020-07-20 15:03 ` Christophe de Dinechin
2020-06-24 13:10 ` [PATCH v5 10/10] chardev: enable modules, use for braille Gerd Hoffmann
2020-07-20 15:06 ` Christophe de Dinechin
2020-07-21 14:35 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lywo2wgeff.fsf@redhat.com \
--to=dinechin@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.