All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miroslav Zubcic <mvz@nimium.com>
To: Pekka Pietikainen <pp@ee.oulu.fi>
Cc: linux-kernel@vger.kernel.org, pavel@ucw.cz, netdev@oss.sgi.com,
	jgarzik@pobox.com
Subject: Re: [PATCH] Re: ethernet/b44: Bug in b44.c:v0.93 (Mar, 2004) ethernet driver in 2.6.6
Date: Sat, 15 May 2004 20:07:50 +0200	[thread overview]
Message-ID: <lzbrkp36rr.fsf@anthea.home.int> (raw)
In-Reply-To: <20040515121112.GA9579@ee.oulu.fi> (Pekka Pietikainen's message of "Sat, 15 May 2004 15:11:12 +0300")

Pekka Pietikainen <pp@ee.oulu.fi> writes:

> On Sat, May 15, 2004 at 03:05:19PM +0300, Pekka Pietikainen wrote:
>> +	/* Enable CRC32, set proper LED modes and power on MAC */
>> +	bw32(B44_MAC_CTRL, MAC_CTRL_CRC32_ENAB | MAC_CTRL_PHY_LEDCTRL);
> Erk, that comment should of course be "power on PHY". I hate acronyms...
>
> --- linux-2.6.5-1.358/drivers/net/b44.c.orig	2004-05-15 13:59:57.000000000 +0300
> +++ linux-2.6.5-1.358/drivers/net/b44.c	2004-05-15 14:59:39.794720368 +0300
> @@ -27,8 +27,8 @@

Pekka, thank you very much for your patch. It looks like things are
working now:

dmesg part:
b44.c:v0.95 (May 15, 2004)
...
eth0: Broadcom 4400 10/100BaseT Ethernet 00:08:02:e2:2d:ba
ip_tables: (C) 2000-2002 Netfilter core team
b44: eth0: Link is down.
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is off for TX and off for RX.

I have tried moving large packets, NFS, ping etc ... no problem
anymore, it works.

Thanks again!


-- 
		The Network is the Filesystem.


  reply	other threads:[~2004-05-15 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13 23:17 ethernet/b44: Bug in b44.c:v0.93 (Mar, 2004) ethernet driver in 2.6.6 Miroslav Zubcic
2004-05-14 13:02 ` Pekka Pietikainen
2004-05-15 12:05   ` [PATCH] " Pekka Pietikainen
2004-05-15 12:11     ` Pekka Pietikainen
2004-05-15 18:07       ` Miroslav Zubcic [this message]
2004-05-15 18:59       ` Jeff Garzik
2004-05-15 22:46     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzbrkp36rr.fsf@anthea.home.int \
    --to=mvz@nimium.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=pavel@ucw.cz \
    --cc=pp@ee.oulu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.