From: ebiederm@xmission.com (Eric W. Biederman)
To: Julia Lawall <julia@diku.dk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/12] genericirq: make irq_chip related function to take desc
Date: Sun, 21 Mar 2010 17:36:51 -0700 [thread overview]
Message-ID: <m11vfdyyxo.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1003212035220.12371@ask.diku.dk> (Julia Lawall's message of "Sun\, 21 Mar 2010 20\:36\:35 +0100 \(CET\)")
Julia Lawall <julia@diku.dk> writes:
> Here is the list of potential trouble spots. This is from a slightly
> older version of Linux than the patch, so the line numbers don't match up.
> But the function names are probably good enough to find the problem.
Thanks for doing all of this. The set of trouble spots in particular
looks like a useful list.
> julia
>
> function definition not found:
> arch/arm/mach-iop13xx/msi.c::167: unmask_msi_irq
> arch/arm/mach-iop13xx/msi.c::168: mask_msi_irq
> arch/arm/mach-iop13xx/msi.c::169: mask_msi_irq
> arch/arm/mach-iop13xx/msi.c::170: unmask_msi_irq
> arch/arm/mach-s3c2410/bast-irq.c::109: bast_pc104_maskack
> arch/arm/mach-s3c2412/irq.c::108: s3c_irq_wake
> arch/arm/mach-s3c2412/irq.c::109: s3c_irqext_type
> arch/arm/mach-s3c64xx/irq-eint.c::148: s3c_irqext_wake
> arch/arm/plat-s3c24xx/irq.c::241: s3c_irqext_wake
> arch/arm/plat-s3c24xx/irq.c::249: s3c_irq_wake
> arch/arm/plat-s3c24xx/irq.c::91: s3c_irq_wake
> arch/arm/plat-s3c24xx/irq.c::99: s3c_irq_wake
> arch/arm/plat-s5pc1xx/irq-eint.c::179: s3c_irqext_wake
> arch/arm/plat-s5pc1xx/irq-eint.c::257: s3c_irqext_wake
> arch/frv/kernel/irq-mb93093.c::76: frv_fpga_end
> arch/ia64/kernel/iosapic.c::425: iosapic_shutdown_level_irq
> arch/ia64/kernel/iosapic.c::426: iosapic_enable_level_irq
> arch/ia64/kernel/iosapic.c::427: iosapic_disable_level_irq
> arch/ia64/kernel/iosapic.c::428: iosapic_ack_level_irq
> arch/ia64/kernel/iosapic.c::475: iosapic_disable_edge_irq
> arch/ia64/kernel/iosapic.c::476: iosapic_enable_edge_irq
> arch/ia64/kernel/iosapic.c::477: iosapic_disable_edge_irq
> arch/ia64/kernel/iosapic.c::479: iosapic_end_edge_irq
> arch/ia64/kernel/msi_ia64.c::107: mask_msi_irq
> arch/ia64/kernel/msi_ia64.c::108: unmask_msi_irq
> arch/ia64/kernel/msi_ia64.c::163: dmar_msi_unmask
> arch/ia64/kernel/msi_ia64.c::164: dmar_msi_mask
> arch/ia64/sn/kernel/irq.c::280: sn_set_affinity_irq
> arch/ia64/sn/kernel/msi_sn.c::230: mask_msi_irq
> arch/ia64/sn/kernel/msi_sn.c::231: unmask_msi_irq
> arch/m68knommu/platform/coldfire/intc.c::187: intc_irq_unmask
> arch/mips/dec/ioasic-irq.c::86: ack_ioasic_dma_irq
> arch/mips/dec/ioasic-irq.c::87: mask_ioasic_dma_irq
> arch/mips/dec/ioasic-irq.c::88: ack_ioasic_dma_irq
> arch/mips/dec/ioasic-irq.c::89: unmask_ioasic_dma_irq
> arch/mips/kernel/i8259.c::45: plat_set_irq_affinity
> arch/mips/kernel/irq_cpu.c::94: mask_mips_mt_irq
> arch/mips/kernel/irq_cpu.c::96: unmask_mips_mt_irq
> arch/mips/kernel/irq_cpu.c::97: unmask_mips_mt_irq
> arch/powerpc/platforms/cell/axon_msi.c::312: mask_msi_irq
> arch/powerpc/platforms/cell/axon_msi.c::313: unmask_msi_irq
> arch/powerpc/platforms/cell/axon_msi.c::314: unmask_msi_irq
> arch/powerpc/sysdev/cpm2_pic.c::205: cpm2_end_irq
> arch/powerpc/sysdev/fsl_msi.c::47: mask_msi_irq
> arch/powerpc/sysdev/fsl_msi.c::48: unmask_msi_irq
> arch/powerpc/sysdev/mpic_pasemi_msi.c::60: mpic_end_irq
> arch/powerpc/sysdev/mpic_pasemi_msi.c::61: mpic_set_irq_type
> arch/powerpc/sysdev/mpic_pasemi_msi.c::62: mpic_set_affinity
> arch/powerpc/sysdev/mpic_u3msi.c::42: mpic_end_irq
> arch/powerpc/sysdev/mpic_u3msi.c::43: mpic_set_irq_type
> arch/powerpc/sysdev/mpic_u3msi.c::44: mpic_set_affinity
> arch/sparc/kernel/pci_msi.c::116: mask_msi_irq
> arch/sparc/kernel/pci_msi.c::117: unmask_msi_irq
> arch/sparc/kernel/pci_msi.c::118: unmask_msi_irq
> arch/sparc/kernel/pci_msi.c::119: mask_msi_irq
> arch/x86/kernel/apic/io_apic.c::3462: unmask_msi_irq
> arch/x86/kernel/apic/io_apic.c::3463: mask_msi_irq
> arch/x86/kernel/apic/io_apic.c::3473: unmask_msi_irq
> arch/x86/kernel/apic/io_apic.c::3474: mask_msi_irq
> arch/x86/kernel/apic/io_apic.c::3634: dmar_msi_unmask
> arch/x86/kernel/apic/io_apic.c::3635: dmar_msi_mask
> arch/x86/kernel/apic/io_apic.c::3689: hpet_msi_unmask
> arch/x86/kernel/apic/io_apic.c::3690: hpet_msi_mask
> arch/x86/kernel/apic/io_apic.c::3702: hpet_msi_unmask
> arch/x86/kernel/apic/io_apic.c::3703: hpet_msi_mask
> arch/x86/kernel/apic/io_apic.c::3788: mask_ht_irq
> arch/x86/kernel/apic/io_apic.c::3789: unmask_ht_irq
> drivers/parisc/dino.c::362: no_ack_irq
> drivers/parisc/dino.c::363: no_end_irq
> drivers/parisc/eisa.c::197: no_ack_irq
> drivers/parisc/eisa.c::198: no_end_irq
> drivers/parisc/gsc.c::157: no_ack_irq
> drivers/parisc/gsc.c::158: no_end_irq
> drivers/parisc/iosapic.c::738: cpu_ack_irq
> drivers/parisc/superio.c::334: no_ack_irq
> drivers/parisc/superio.c::335: no_end_irq
>
> initialization to local variable:
> arch/arm/mach-pxa/irq.c::120: fn
> arch/arm/mach-pxa/irq.c::151: fn
> arch/arm/mach-pxa/pxa3xx.c::573: fn
> arch/arm/plat-pxa/gpio.c::294: fn
>
> non-call use of a function:
> arch/ia64/kernel/iosapic.c::417: mask_irq
> arch/ia64/kernel/iosapic.c::418: unmask_irq
> arch/ia64/kernel/iosapic.c::419: mask_irq
> arch/ia64/kernel/iosapic.c::468: unmask_irq
> arch/microblaze/kernel/intc.c::121: intc_enable_or_unmask
> arch/microblaze/kernel/intc.c::122: intc_disable_or_mask
> arch/microblaze/kernel/intc.c::123: intc_mask_ack
> arch/microblaze/kernel/intc.c::124: intc_ack
> arch/microblaze/kernel/intc.c::125: intc_end
> arch/mips/dec/ioasic-irq.c::71: unmask_ioasic_irq
> arch/mips/dec/ioasic-irq.c::73: mask_ioasic_irq
> arch/mips/dec/ioasic-irq.c::75: ack_ioasic_irq
> arch/mips/kernel/irq_cpu.c::64: unmask_mips_irq
> arch/mips/kernel/irq_cpu.c::65: mask_mips_irq
> arch/mn10300/kernel/irq.c::76: mn10300_cpupic_mask
> arch/x86/kernel/i8259.c::397: legacy_pic_uint_noop
> arch/xtensa/variants/s6000/gpio.c::169: mask
> arch/xtensa/variants/s6000/gpio.c::192: mask
> arch/xtensa/variants/s6000/gpio.c::195: mask
> arch/xtensa/variants/s6000/gpio.c::198: mask
> arch/xtensa/variants/s6000/gpio.c::201: mask
> arch/xtensa/variants/s6000/gpio.c::204: mask
> arch/xtensa/variants/s6000/gpio.c::209: mask
> arch/xtensa/variants/s6000/gpio.c::216: mask
> arch/xtensa/variants/s6000/gpio.c::219: mask
> arch/xtensa/variants/s6000/gpio.c::221: mask
> arch/xtensa/variants/s6000/gpio.c::224: mask
> include/linux/kernel.h::41: mask
> kernel/irq/chip.c::345: default_disable
>
> non-static function:
> arch/alpha/kernel/irq_i8259.c::88: i8259a_startup_irq
> arch/alpha/kernel/irq_i8259.c::89: i8259a_disable_irq
> arch/alpha/kernel/irq_i8259.c::90: i8259a_enable_irq
> arch/alpha/kernel/irq_i8259.c::91: i8259a_disable_irq
> arch/alpha/kernel/irq_i8259.c::92: i8259a_mask_and_ack_irq
> arch/alpha/kernel/irq_i8259.c::93: i8259a_end_irq
> arch/arm/mach-msm/board-sapphire-gpio.c::264: sapphire_gpio_irq_set_wake
> arch/arm/mach-msm/board-trout-gpio.c::248: trout_gpio_irq_set_wake
> arch/arm/plat-s3c24xx/irq.c::240: s3c_irqext_type
> arch/arm/plat-s3c24xx/irq.c::250: s3c_irqext_type
> arch/blackfin/mach-common/ints-priority.c::274: bfin_internal_set_wake
> arch/blackfin/mach-common/ints-priority.c::937: bfin_gpio_set_wake
> arch/cris/arch-v32/kernel/irq.c::346: set_affinity_crisv32_irq
> arch/mips/jazz/irq.c::49: disable_r4030_irq
> arch/mips/jazz/irq.c::50: disable_r4030_irq
> arch/mips/jazz/irq.c::51: disable_r4030_irq
> arch/mips/lasat/interrupt.c::49: disable_lasat_irq
> arch/mips/lasat/interrupt.c::50: disable_lasat_irq
> arch/mips/lasat/interrupt.c::51: disable_lasat_irq
> arch/mips/lasat/interrupt.c::52: enable_lasat_irq
> arch/mips/sni/pcimt.c::218: disable_pcimt_irq
> arch/mips/sni/pcimt.c::219: disable_pcimt_irq
> arch/mips/sni/pcimt.c::220: disable_pcimt_irq
> arch/mips/sni/pcit.c::180: disable_pcit_irq
> arch/mips/sni/pcit.c::181: disable_pcit_irq
> arch/mips/sni/pcit.c::182: disable_pcit_irq
> arch/mips/sni/pcit.c::184: end_pcit_irq
> arch/mips/sni/rm200.c::289: sni_rm200_mask_and_ack_8259A
> arch/mips/sni/rm200.c::453: disable_rm200_irq
> arch/mips/sni/rm200.c::454: disable_rm200_irq
> arch/mips/sni/rm200.c::455: disable_rm200_irq
> arch/mips/sni/rm200.c::457: end_rm200_irq
> arch/powerpc/sysdev/mpic.c::907: mpic_mask_irq
> arch/powerpc/sysdev/mpic.c::908: mpic_unmask_irq
> arch/powerpc/sysdev/mpic.c::909: mpic_end_irq
> arch/powerpc/sysdev/mpic.c::910: mpic_set_irq_type
> arch/powerpc/sysdev/mpic.c::925: mpic_mask_irq
> arch/powerpc/sysdev/mpic.c::928: mpic_set_irq_type
> arch/sh/boards/mach-cayman/irq.c::100: disable_cayman_irq
>
> non-test or call reference to field:
> kernel/irq/manage.c::432: set_type
>
> non-updated function:
> arch/arm/mach-s3c2410/bast-irq.c::109: bast_pc104_maskack
> arch/m68knommu/platform/coldfire/intc.c::129: intc_irq_unmask
> arch/powerpc/sysdev/cpm2_pic.c::116: cpm2_end_irq
next prev parent reply other threads:[~2010-03-22 0:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 10:08 [PATCH 0/12] irq related: make function to take irq_desc pointer instead of irq Yinghai Lu
2010-03-04 10:08 ` [PATCH 01/12] x86: fix out of order of gsi - full Yinghai Lu
2010-03-04 10:08 ` [PATCH 02/12] x86: set nr_irqs_gsi only in probe_nr_irqs_gsi Yinghai Lu
2010-03-04 10:08 ` [PATCH 03/12] x86: kill smpboot_hooks.h Yinghai Lu
2010-03-04 10:08 ` [PATCH 04/12] x86: use vector_desc instead of vector_irq Yinghai Lu
2010-03-04 10:08 ` [PATCH 05/12] genericirq: make irq_chip to have member with irq_desc pointer Yinghai Lu
2010-03-04 10:08 ` [PATCH 06/12] genericirq: make irq_chip related function to take desc Yinghai Lu
2010-03-04 14:31 ` Thomas Gleixner
2010-03-04 18:56 ` Yinghai Lu
2010-03-04 19:08 ` Thomas Gleixner
2010-03-04 19:20 ` Yinghai Lu
2010-03-05 7:47 ` Julia Lawall
2010-03-21 4:18 ` Eric W. Biederman
2010-03-21 11:03 ` Julia Lawall
2010-03-21 13:11 ` [PATCH] irq: Start the transition of irq_chip methods taking a desc Eric W. Biederman
2010-03-21 13:11 ` Eric W. Biederman
2010-03-21 14:43 ` Thomas Gleixner
2010-03-21 18:50 ` Yinghai Lu
2010-03-22 0:32 ` Eric W. Biederman
2010-03-21 13:49 ` [PATCH 06/12] genericirq: make irq_chip related function to take desc Eric W. Biederman
2010-03-21 14:19 ` Julia Lawall
2010-03-21 16:29 ` Julia Lawall
2010-03-21 11:08 ` Julia Lawall
2010-03-21 11:43 ` Eric W. Biederman
2010-03-21 19:16 ` Julia Lawall
2010-03-21 19:35 ` Julia Lawall
2010-03-21 19:36 ` Julia Lawall
2010-03-22 0:36 ` Eric W. Biederman [this message]
2010-03-04 19:18 ` Yinghai Lu
2010-03-04 10:08 ` [PATCH 07/12] genericirq: make hpet_msi/ht/msi/dmar_msi " Yinghai Lu
2010-03-04 10:08 ` [PATCH 08/12] x86: make irq_chip to use desc_mask instead of mask Yinghai Lu
2010-03-04 15:10 ` [PATCH 08/12] x86: make irq_chip to use desc_mask instead of maskn Thomas Gleixner
2010-03-04 10:08 ` [PATCH 09/12] x86: irq_chip to use desc_mask instead of mask part 2 Yinghai Lu
2010-03-04 10:08 ` [PATCH 10/12] genericirq: add set_irq_desc_chip/data Yinghai Lu
2010-03-04 10:08 ` [PATCH 11/12] x86/iommu/dmar: update iommu/inter_remapping to use desc Yinghai Lu
2010-03-04 10:08 ` [PATCH 12/12] x86: remove arch_probe_nr_irqs Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11vfdyyxo.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.