From: ebiederm@xmission.com (Eric W. Biederman)
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: [PATCH] pci: change msi-x vector to 32bit
Date: Sat, 16 Aug 2008 01:17:12 -0700 [thread overview]
Message-ID: <m11w0p74s7.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <200808160326.m7G3QR1G012726@terminus.zytor.com> (H. Peter Anvin's message of "Fri, 15 Aug 2008 20:26:33 -0700")
"H. Peter Anvin" <hpa@zytor.com> writes:
> The 28 bits aren't enough, are they: we need domain as well (and surely we can
> have more than 16 domains?)
The justification is questionable. The fact that the irq number
reported for msi-x vectors is only 16bits is a bug. Everywhere else
in the kernel an irq number is stored in a 32bit field.
We also have a few other bits of craziness in the msix interface.
The entry field in msix_entry is unnecessary.
In fact now that we have a linked list of irq entries we stop passing
the structure entirely.
Eric
next prev parent reply other threads:[~2008-08-16 8:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 3:26 [PATCH] pci: change msi-x vector to 32bit H. Peter Anvin
2008-08-16 6:42 ` Yinghai Lu
2008-08-16 14:50 ` James Bottomley
2008-08-16 15:39 ` Alan Cox
2008-08-16 16:13 ` James Bottomley
2008-08-16 18:56 ` Yinghai Lu
2008-08-16 20:10 ` Andrew Vasquez
2008-08-16 20:25 ` James Bottomley
2008-08-16 20:34 ` Yinghai Lu
2008-08-16 20:45 ` James Bottomley
2008-08-16 22:17 ` Yinghai Lu
2008-08-16 23:09 ` James Bottomley
2008-08-16 23:21 ` Yinghai Lu
2008-08-18 19:59 ` Eric W. Biederman
2008-08-18 20:59 ` James Bottomley
2008-08-18 21:45 ` Eric W. Biederman
2008-08-18 22:04 ` James Bottomley
2008-08-18 21:51 ` Alan Cox
2008-08-18 22:13 ` H. Peter Anvin
2008-08-18 22:27 ` James Bottomley
2008-08-18 21:24 ` H. Peter Anvin
2008-08-16 8:17 ` Eric W. Biederman [this message]
2008-08-16 9:00 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2008-08-16 2:36 Yinghai Lu
2008-08-21 20:33 ` Jesse Barnes
2008-08-21 20:47 ` Eric W. Biederman
2008-08-21 23:07 ` Jesse Barnes
2008-08-22 0:11 ` Eric W. Biederman
2008-08-22 0:35 ` Jesse Barnes
2008-08-27 23:34 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11w0p74s7.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.vasquez@qlogic.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.