From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@muc.de>
Subject: Re: [PATCH] Fixing stack alignment in x86-64 Xen
Date: Wed, 18 May 2005 16:06:18 +0200
Message-ID: <m11x846339.fsf@muc.de>
References: <7F740D512C7C1046AB53446D3720017304021C2C@scsmsx402.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <7F740D512C7C1046AB53446D3720017304021C2C@scsmsx402.amr.corp.intel.com>
	(Jun Nakajima's message of "Tue, 17 May 2005 19:25:46 -0700")
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

"Nakajima, Jun" <jun.nakajima@intel.com> writes:

> Long mode needs to align the stack on a 16-byte boundary. Recent changes
> to Xen broke the requirement, and x86-64 XenLinux stopped booting. The
> attached fixes the problem. 

Normally it should be only needed in user space for saving FP registers.
The kernel and Xen which should not do this probably don't need it.

Unless you save FP registers on the stack somewhere. Then I would
rather fix that place only.

At least the main linux kernel does not try to keep the stack
always 16byte aligned. There is even a gcc option to turn it off
and it saves some code (and probably stack) size.

-Andi