From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1S5VG3-0004HV-Ch for kexec@lists.infradead.org; Thu, 08 Mar 2012 04:47:20 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <20120216172735.GX9751@redhat.com> <20120216215603.GH9751@redhat.com> <20120217195430.GO9751@redhat.com> <20120220151419.GU9751@redhat.com> <20120221135934.GF26998@redhat.com> <4F573E1C.2060909@oss.ntt.co.jp> <4F573E74.5040504@oss.ntt.co.jp> <4F573EF0.1080501@oss.ntt.co.jp> Date: Wed, 07 Mar 2012 20:50:35 -0800 In-Reply-To: <4F573EF0.1080501@oss.ntt.co.jp> ("Fernando Luis =?utf-8?Q?V?= =?utf-8?Q?=C3=A1zquez?= Cao"'s message of "Wed, 07 Mar 2012 19:56:48 +0900") Message-ID: MIME-Version: 1.0 Subject: Re: [PATCH 2/2] boot: add early NMI counter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Fernando Luis =?utf-8?Q?V=C3=A1zquez?= Cao Cc: Don Zickus , linux-tip-commits@vger.kernel.org, torvalds@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu, Yinghai Lu , akpm@linux-foundation.org, vgoyal@redhat.com RmVybmFuZG8gTHVpcyBWw6F6cXVleiBDYW8gPGZlcm5hbmRvQG9zcy5udHQuY28uanA+IHdyaXRl czoKCj4gU3ViamVjdDogW1BBVENIXSBib290OiBhZGQgZWFybHkgTk1JIGNvdW50ZXIKPgo+IEZy b206IEZlcm5hbmRvIEx1aXMgVmF6cXVleiBDYW8gPGZlcm5hbmRvQG9zcy5udHQuY28uanA+Cj4K PiBXZSBjdXJyZW50bHkgaWdub3JlIGVhcmx5IE5NSXMgYnV0IGl0IHdvdWxkIGJlIG5pY2UgdG8g YmUgYWJsZSB0bwo+IGtub3cgd2hldGhlciB0aGV5IGFjdHVhbGx5IG9jY3VycmVkLgo+Cj4gVGhp cyBwYXRjaCBhZGRzIGFuIGVhcmx5IE5NSSBjb3VudGVyIGFuZCBleHBvcnRzIGl0IHRyb3VnaAo+ IC9wcm9jL2ludGVycnVwdHMgd2l0aCB0aGUgbmFtZSBvZiBFTk0gKEVhcmx5IE5NSSkuCgpGb3Ig YSB1c2Vyc3BhY2UgaW50ZXJmYWNlIEkgc3VzcGVjdCB3ZSBqdXN0IHdhbnQgdG8gZHVtcCB0aGUg Y291bnQKaW50byB0aGUgTk1JIGNvdW50ZXIuCgpJdCBwcm9iYWJseSBtYWtlcyBzZW5zZSB0byBo YXZlIGEgc2VwYXJhdGUgdmFyaWFibGUgaW4gZWFybHkgYm9vdCBsaWtlCnlvdSBkbywgYnV0IHRo ZW4gYWJvdXQgdGhlIHRpbWUgd2Ugc2V0dXAgdGhlIG5vcm1hbCBOTUkgaGFuZGxlciBtb3ZlIHRo ZQpOTUkgY291bnQgb3ZlciBhbmQgcG9zc2libHkgZG8gc29tZXRoaW5nIGxpa2UgcmVib290IGlm IHRoYXQgaXMgb3VyCnBvbGljeS4KCkkgZG9uJ3Qgc2VlIGl0IG1ha2luZyBzZW5zZSB0byBlZHVj YXRlIHVzZXJzcGFjZSBmb3IgYW4gZWRnZSBjYXNlIGxpa2UKdGhpcy4KCkVyaWMKCgo+IFNpZ25l ZC1vZmYtYnk6IEZlcm5hbmRvIEx1aXMgVmF6cXVleiBDYW8gPGZlcm5hbmRvQG9zcy5udHQuY28u anA+Cj4gLS0tCj4KPiBkaWZmIC11ck5wIGxpbnV4LTMuMy1yYzYtb3JpZy9hcmNoL3g4Ni9pbmNs dWRlL2FzbS9wcm9jZXNzb3IuaCBsaW51eC0zLjMtcmM2L2FyY2gveDg2L2luY2x1ZGUvYXNtL3By b2Nlc3Nvci5oCj4gLS0tIGxpbnV4LTMuMy1yYzYtb3JpZy9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9w cm9jZXNzb3IuaAkyMDEyLTAzLTA3IDE1OjQ5OjAxLjgyNjI0MTY4MiArMDkwMAo+ICsrKyBsaW51 eC0zLjMtcmM2L2FyY2gveDg2L2luY2x1ZGUvYXNtL3Byb2Nlc3Nvci5oCTIwMTItMDMtMDcgMTg6 NTI6MjcuNjY4MDU0MTIyICswOTAwCj4gQEAgLTQwMiw2ICs0MDIsNyBAQCBERUNMQVJFX1BFUl9D UFUoY2hhciAqLCBpcnFfc3RhY2tfcHRyKTsKPiAgREVDTEFSRV9QRVJfQ1BVKHVuc2lnbmVkIGlu dCwgaXJxX2NvdW50KTsKPiAgZXh0ZXJuIHVuc2lnbmVkIGxvbmcga2VybmVsX2VmbGFnczsKPiAg ZXh0ZXJuIGFzbWxpbmthZ2Ugdm9pZCBpZ25vcmVfc3lzcmV0KHZvaWQpOwo+ICtleHRlcm4gdW5z aWduZWQgaW50IGVhcmx5X25taV9jb3VudDsKPiAgI2Vsc2UJLyogWDg2XzY0ICovCj4gICNpZmRl ZiBDT05GSUdfQ0NfU1RBQ0tQUk9URUNUT1IKPiAgLyoKPiBkaWZmIC11ck5wIGxpbnV4LTMuMy1y YzYtb3JpZy9hcmNoL3g4Ni9rZXJuZWwvaGVhZF82NC5TIGxpbnV4LTMuMy1yYzYvYXJjaC94ODYv a2VybmVsL2hlYWRfNjQuUwo+IC0tLSBsaW51eC0zLjMtcmM2LW9yaWcvYXJjaC94ODYva2VybmVs L2hlYWRfNjQuUwkyMDEyLTAzLTA3IDE4OjUxOjE3LjU4MzE2MDExNCArMDkwMAo+ICsrKyBsaW51 eC0zLjMtcmM2L2FyY2gveDg2L2tlcm5lbC9oZWFkXzY0LlMJMjAxMi0wMy0wNyAxODo1NDozNy4y MDU2OTk0MjIgKzA5MDAKPiBAQCAtMzI3LDYgKzMyNyw3IEBAIGVhcmx5X2V4Y2VwdGlvbl9oYW5k bGVyOgo+ICAJam1wIDFiCj4gIAo+ICBlYXJseV9ubWlfaGFuZGxlcjoKPiArCWluY2wgZWFybHlf bm1pX2NvdW50KCVyaXApICMgZXhwb3J0ZWQgYXMgRU5NIGluIC9wcm9jL2ludGVycnVwdHMKPiAg CWlyZXRxCj4gIAo+ICAjaWZkZWYgQ09ORklHX0VBUkxZX1BSSU5USwo+IEBAIC0zNDAsNiArMzQx LDEwIEBAIGVhcmx5X2lkdF9yaXBtc2c6Cj4gICNlbmRpZiAvKiBDT05GSUdfRUFSTFlfUFJJTlRL ICovCj4gIAkucHJldmlvdXMKPiAgCj4gKwkuZ2xvYmwgZWFybHlfbm1pX2NvdW50Cj4gK2Vhcmx5 X25taV9jb3VudDoKPiArCS5sb25nIDAKPiArCj4gICNkZWZpbmUgTkVYVF9QQUdFKG5hbWUpIFwK PiAgCS5iYWxpZ24JUEFHRV9TSVpFOyBcCj4gIEVOVFJZKG5hbWUpCj4gZGlmZiAtdXJOcCBsaW51 eC0zLjMtcmM2LW9yaWcvYXJjaC94ODYva2VybmVsL2lycS5jIGxpbnV4LTMuMy1yYzYvYXJjaC94 ODYva2VybmVsL2lycS5jCj4gLS0tIGxpbnV4LTMuMy1yYzYtb3JpZy9hcmNoL3g4Ni9rZXJuZWwv aXJxLmMJMjAxMi0wMy0wNyAxNTo0OTowMS44MzgyNDE4MzkgKzA5MDAKPiArKysgbGludXgtMy4z LXJjNi9hcmNoL3g4Ni9rZXJuZWwvaXJxLmMJMjAxMi0wMy0wNyAxODo1NToxNC4wNzgxNzk0NDgg KzA5MDAKPiBAQCAtMTI1LDYgKzEyNSw3IEBAIGludCBhcmNoX3Nob3dfaW50ZXJydXB0cyhzdHJ1 Y3Qgc2VxX2ZpbGUKPiAgI2lmIGRlZmluZWQoQ09ORklHX1g4Nl9JT19BUElDKQo+ICAJc2VxX3By aW50ZihwLCAiJSpzOiAlMTB1XG4iLCBwcmVjLCAiTUlTIiwgYXRvbWljX3JlYWQoJmlycV9taXNf Y291bnQpKTsKPiAgI2VuZGlmCj4gKwlzZXFfcHJpbnRmKHAsICIlKnM6ICUxMHVcbiIsIHByZWMs ICJFTk0iLCBlYXJseV9ubWlfY291bnQpOwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxp c3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577Ab2CHErV (ORCPT ); Wed, 7 Mar 2012 23:47:21 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:56591 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800Ab2CHErS convert rfc822-to-8bit (ORCPT ); Wed, 7 Mar 2012 23:47:18 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Fernando Luis =?utf-8?Q?V=C3=A1zquez?= Cao Cc: Don Zickus , linux-tip-commits@vger.kernel.org, Yinghai Lu , mingo@elte.hu, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, tglx@linutronix.de, vgoyal@redhat.com References: <20120216172735.GX9751@redhat.com> <20120216215603.GH9751@redhat.com> <20120217195430.GO9751@redhat.com> <20120220151419.GU9751@redhat.com> <20120221135934.GF26998@redhat.com> <4F573E1C.2060909@oss.ntt.co.jp> <4F573E74.5040504@oss.ntt.co.jp> <4F573EF0.1080501@oss.ntt.co.jp> Date: Wed, 07 Mar 2012 20:50:35 -0800 In-Reply-To: <4F573EF0.1080501@oss.ntt.co.jp> ("Fernando Luis =?utf-8?Q?V?= =?utf-8?Q?=C3=A1zquez?= Cao"'s message of "Wed, 07 Mar 2012 19:56:48 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/n6oOXiVJaKhCp1X5sZCOZPnO+8Zb/9Mg= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.4 UNTRUSTED_Relay Comes from a non-trusted relay X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?;Fernando Luis V=c3=a1zquez Cao ?= X-Spam-Relay-Country: ** Subject: Re: [PATCH 2/2] boot: add early NMI counter X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 06 Aug 2010 16:31:04 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fernando Luis Vázquez Cao writes: > Subject: [PATCH] boot: add early NMI counter > > From: Fernando Luis Vazquez Cao > > We currently ignore early NMIs but it would be nice to be able to > know whether they actually occurred. > > This patch adds an early NMI counter and exports it trough > /proc/interrupts with the name of ENM (Early NMI). For a userspace interface I suspect we just want to dump the count into the NMI counter. It probably makes sense to have a separate variable in early boot like you do, but then about the time we setup the normal NMI handler move the NMI count over and possibly do something like reboot if that is our policy. I don't see it making sense to educate userspace for an edge case like this. Eric > Signed-off-by: Fernando Luis Vazquez Cao > --- > > diff -urNp linux-3.3-rc6-orig/arch/x86/include/asm/processor.h linux-3.3-rc6/arch/x86/include/asm/processor.h > --- linux-3.3-rc6-orig/arch/x86/include/asm/processor.h 2012-03-07 15:49:01.826241682 +0900 > +++ linux-3.3-rc6/arch/x86/include/asm/processor.h 2012-03-07 18:52:27.668054122 +0900 > @@ -402,6 +402,7 @@ DECLARE_PER_CPU(char *, irq_stack_ptr); > DECLARE_PER_CPU(unsigned int, irq_count); > extern unsigned long kernel_eflags; > extern asmlinkage void ignore_sysret(void); > +extern unsigned int early_nmi_count; > #else /* X86_64 */ > #ifdef CONFIG_CC_STACKPROTECTOR > /* > diff -urNp linux-3.3-rc6-orig/arch/x86/kernel/head_64.S linux-3.3-rc6/arch/x86/kernel/head_64.S > --- linux-3.3-rc6-orig/arch/x86/kernel/head_64.S 2012-03-07 18:51:17.583160114 +0900 > +++ linux-3.3-rc6/arch/x86/kernel/head_64.S 2012-03-07 18:54:37.205699422 +0900 > @@ -327,6 +327,7 @@ early_exception_handler: > jmp 1b > > early_nmi_handler: > + incl early_nmi_count(%rip) # exported as ENM in /proc/interrupts > iretq > > #ifdef CONFIG_EARLY_PRINTK > @@ -340,6 +341,10 @@ early_idt_ripmsg: > #endif /* CONFIG_EARLY_PRINTK */ > .previous > > + .globl early_nmi_count > +early_nmi_count: > + .long 0 > + > #define NEXT_PAGE(name) \ > .balign PAGE_SIZE; \ > ENTRY(name) > diff -urNp linux-3.3-rc6-orig/arch/x86/kernel/irq.c linux-3.3-rc6/arch/x86/kernel/irq.c > --- linux-3.3-rc6-orig/arch/x86/kernel/irq.c 2012-03-07 15:49:01.838241839 +0900 > +++ linux-3.3-rc6/arch/x86/kernel/irq.c 2012-03-07 18:55:14.078179448 +0900 > @@ -125,6 +125,7 @@ int arch_show_interrupts(struct seq_file > #if defined(CONFIG_X86_IO_APIC) > seq_printf(p, "%*s: %10u\n", prec, "MIS", atomic_read(&irq_mis_count)); > #endif > + seq_printf(p, "%*s: %10u\n", prec, "ENM", early_nmi_count); > return 0; > } >