From: ebiederm@xmission.com (Eric W. Biederman)
To: Adrian Bunk <bunk@stusta.de>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static
Date: Mon, 13 Nov 2006 14:32:53 -0700 [thread overview]
Message-ID: <m13b8nowvu.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20061113210342.GE22565@stusta.de> (Adrian Bunk's message of "Mon, 13 Nov 2006 22:03:42 +0100")
Adrian Bunk <bunk@stusta.de> writes:
> irq_vector[] can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
I made this change on x86_64 and forgot it can equally apply to i386.
> --- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old 2006-11-13
> 18:13:14.000000000 +0100
> +++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c 2006-11-13
> 18:13:25.000000000 +0100
> @@ -1242,7 +1242,7 @@
> }
>
> /* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
> -u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
> +static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0
> };
>
> static int __assign_irq_vector(int irq)
> {
Eric
next prev parent reply other threads:[~2006-11-13 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 21:03 [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static Adrian Bunk
2006-11-13 21:32 ` Eric W. Biederman [this message]
2006-11-14 6:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m13b8nowvu.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.