From: ebiederm@xmission.com (Eric W. Biederman)
To: Or Gerlitz <ogerlitz@voltaire.com>
Cc: Roland Dreier <rdreier@cisco.com>, <netdev@vger.kernel.org>
Subject: Re: correct include file for restart_syscall
Date: Mon, 13 Dec 2010 02:51:26 -0800 [thread overview]
Message-ID: <m14oaivtch.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1012131211001.17382@zuben.voltaire.com> (Or Gerlitz's message of "Mon, 13 Dec 2010 12:17:16 +0200")
Or Gerlitz <ogerlitz@voltaire.com> writes:
> Hi,
>
> commit 26574401fef6766f6c3ca25b5c13febe662d2a32 "net: Fix ipoib rtnl_lock
> sysfs deadlock" modified some flows doing rtnl_lock calls to use rtnl_trylock
> / restart_syscall, etc. It turned out that restart_syscall was included in
> ipoib through linux/inet_lro.h which is an include I'd like to remove...
> Is including linux/sched.h being the right thing to do? I wasn't sure as
> this call is very rare, in network drivers its called only by ipoib and
> bonding and it looks like bonding includes it indirectly.
For the definition of restart_syscall yes.
I wish I was clever enough to find a way not to need rtnl_trylock
restart_syscall but unfortunately I don't :(
Eric
prev parent reply other threads:[~2010-12-13 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 10:17 correct include file for restart_syscall Or Gerlitz
2010-12-13 10:51 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14oaivtch.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.