From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support. Date: Wed, 02 Jul 2008 09:49:33 -0700 Message-ID: References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <486B060C.7030607@gmail.com> (Tejun Heo's message of "Wed, 02 Jul 2008 13:37:32 +0900") Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: Benjamin Thery , Greg Kroah-Hartman , Andrew Morton , Daniel Lezcano , Serge Hallyn , linux-kernel@vger.kernel.org, Al Viro , Linux Containers List-Id: containers.vger.kernel.org Tejun Heo writes: > Is it difficult to just export it via kobject and device layer? Well gregkh thought it wasn't a good idea last time I tried exploring that. > If > changing the default function is too much of a hassle (and I'm sure it > would be), just add an extended version which takes @tag. The current > implementation feels like it tried too hard to not add intermediate > interfaces and ended up shooting outside from the innermost layer. It tried for something that was simple to use and that worked. Also the way things work. I have to use all of the intermediate layers and their calls to various functions. So just passing a parameter through doesn't work to well. It looks to me like the clean solution is move kobject_tag into kobj_type, and have it call some higher level function. We also need to remove the maintenance disaster that is kobject_set_name from sysfs_rename_dir. And push it into kobject_rename instead. The error handling is harder in that case but otherwise we should be in good shape. >> On the other side I can't pass a tag through from the device layer to >> the kobject layer. It isn't a concept the kobject layer supports. > > I think it's best to make kobject layer support it. Assuming Greg will accept it when he sees reasonable patches. Eric