Re: [ANNOUNCE] Adaptec SAS/SATA device driver [17/27]

[Andi Kleen <ak@muc.de>]

Luben Tuikov <luben_tuikov@adaptec.com> writes:


> +/********************************** Misc Macros *******************************/

[... lots of code...]

What are they all good for? As far as I can see every one of them
duplicates or wraps something Linux already has.

How about you just use the native Linux functions directly?

 +
> +#if KDB_ENABLE
> +#define ASSERT(expression)						\
> +	if (!(expression)) {						\
> +		printk("assertion failed: %s, file: %s, line: %d\n",	\
> +			#expression, __FILE__, __LINE__);		\
> +		KDB_ENTER();						\
> +	}
> +#else
> +#define ASSERT(expression)						\
> +	if (!(expression)) {						\
> +		panic("assertion failed: %s, file: %s, line: %d\n",	\
> +			#expression, __FILE__, __LINE__);		\
> +	}
> +#endif

That's called BUG_ON in Linux land.

> +#ifndef list_for_each_entry_safe

[...]

Such compat code does not really belong into a 2.6 driver.

> +
> +#define list_move_all(to_list, from_list)				\

[...]

And this should be put into list.h

-Andi