From: Rusty Russell <rusty@rustcorp.com.au>
To: "Alan J. Wylie" <alan.nospam@glaramara.freeserve.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ipt_unclean: TCP flags bad: 4
Date: Mon, 23 Jul 2001 18:43:26 +1000 [thread overview]
Message-ID: <m15ObJH-000CD5C@localhost> (raw)
In-Reply-To: Your message of "Sun, 22 Jul 2001 16:27:26 +0100." <15194.61662.338810.87576@glaramara.freeserve.co.uk>
In message <15194.61662.338810.87576@glaramara.freeserve.co.uk> you write:
>
> I've just upgraded to 2.4.7, and I'm getting lots of errors:
>
> ipt_unclean: TCP flags bad: 4
Please try this patch...
Note that this should be a warning to people not to reject packets
based on ipt_unclean, or we'll end up with another situation like the
ECN blackholes when the next Funky New Thing comes along...
Thanks,
Rusty.
--
Premature optmztion is rt of all evl. --DK
diff -urN -I \$.*\$ -X /home/rusty/devel/kernel/kernel-patches/dontdiff --minimal linux-2.4.7-official/net/ipv4/netfilter/ipt_unclean.c working-2.4.7-unclean/net/ipv4/netfilter/ipt_unclean.c
--- linux-2.4.7-official/net/ipv4/netfilter/ipt_unclean.c Sun Jul 22 13:13:27 2001
+++ working-2.4.7-unclean/net/ipv4/netfilter/ipt_unclean.c Mon Jul 23 18:29:11 2001
@@ -331,6 +331,7 @@
tcpflags = ((u_int8_t *)tcph)[13];
if (tcpflags != TH_SYN
&& tcpflags != (TH_SYN|TH_ACK)
+ && tcpflags != TH_RST
&& tcpflags != (TH_RST|TH_ACK)
&& tcpflags != (TH_RST|TH_ACK|TH_PUSH)
&& tcpflags != (TH_FIN|TH_ACK)
next prev parent reply other threads:[~2001-07-23 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-22 15:27 ipt_unclean: TCP flags bad: 4 Alan J. Wylie
2001-07-22 17:51 ` Luigi Genoni
2001-07-22 18:10 ` Alan J. Wylie
2001-07-22 23:07 ` Luigi Genoni
2001-07-23 8:43 ` Rusty Russell [this message]
2001-07-23 20:55 ` Alan J. Wylie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m15ObJH-000CD5C@localhost \
--to=rusty@rustcorp.com.au \
--cc=alan.nospam@glaramara.freeserve.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.