From: arjan@fenrus.demon.nl
To: jussi.laako@kolumbus.fi (Jussi Laako)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Additions to full lowlatency patch
Date: Sat, 12 Jan 2002 22:03:21 +0000 (GMT) [thread overview]
Message-ID: <m16PWFF-000OVeC@amadeus.home.nl> (raw)
In-Reply-To: <3C40AF23.18C811A8@kolumbus.fi>
In article <3C40AF23.18C811A8@kolumbus.fi> you wrote:
> --- linux-2.4.17-lowlatency/drivers/net/eepro100.c Fri Dec 21 19:41:54 2001
> +++ linux-2.4.17-lowlatency-jl/drivers/net/eepro100.c Mon Dec 31 22:41:42 2001
> @@ -324,7 +324,11 @@
> static inline void wait_for_cmd_done(long cmd_ioaddr)
> {
> int wait = 1000;
> - do udelay(1) ;
> + do
> + {
> + conditional_schedule();
> + udelay(1) ;
> + }
> while(inb(cmd_ioaddr) && --wait >= 0);
> #ifndef final_version
> if (wait < 0)
Did you audit all uses of this function ? It sort of looks like you're doing
"hey there's a udelay lets add a schedule".. ok that's a bit rude but I'm
not totally convinced that this function isn't called with spinlocks helt...
next prev parent reply other threads:[~2002-01-12 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-12 21:48 [PATCH] Additions to full lowlatency patch Jussi Laako
2002-01-12 22:03 ` arjan [this message]
2002-01-12 22:38 ` Jussi Laako
2002-01-12 22:21 ` Andrew Morton
2002-01-12 22:54 ` Jussi Laako
2002-01-13 2:47 ` Jussi Laako
2002-01-12 22:26 ` Stephan von Krawczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m16PWFF-000OVeC@amadeus.home.nl \
--to=arjan@fenrus.demon.nl \
--cc=jussi.laako@kolumbus.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.