From: ebiederm@xmission.com (Eric W. Biederman)
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: crash kernel reserve with reserve_early -v2
Date: Sun, 22 Nov 2009 21:12:45 -0800 [thread overview]
Message-ID: <m17hthj036.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4B0A0341.9090305@kernel.org> (Yinghai Lu's message of "Sun\, 22 Nov 2009 19\:36\:33 -0800")
Yinghai Lu <yinghai@kernel.org> writes:
> Eric W. Biederman wrote:
>> Yinghai Lu <yinghai@kernel.org> writes:
>>
>>> use find_e820_area/reserve_early instead.
>>>
>>> -v2: address Eric's request, to restore original semantics.
>>> will fail, if the provided address can not be used.
>>
>> This patch seems reasonable.
>>
>> YH what is the benefit of using reserve_early, and moving
>> reserve_crashkernel earlier?
>
> old way mixing find_e820_area and reserve_bootmem like bandit...
Sounds like bitrot of the best practices.
> also there are some effects to remove bootmem, so we try to reduce bootmem reference.
Makes sense. Extent based allocators early allocators are much more efficient.
Eric
next prev parent reply other threads:[~2009-11-23 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 1:18 [PATCH] x86: crash kernel reserve with reserve_early -v2 Yinghai Lu
2009-11-23 2:34 ` Eric W. Biederman
2009-11-23 3:36 ` Yinghai Lu
2009-11-23 5:12 ` Eric W. Biederman [this message]
2009-11-23 8:42 ` [tip:x86/mm] x86: Change crash kernel to reserve via reserve_early() tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17hthj036.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.