From: ebiederm@xmission.com (Eric W. Biederman)
To: Roland Dreier <roland@digitalvampire.org>
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
Date: Wed, 03 Oct 2007 13:55:10 -0600 [thread overview]
Message-ID: <m17im4c6sh.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <874ph8ovtm.fsf@shaolin.home.digitalvampire.org> (Roland Dreier's message of "Wed, 03 Oct 2007 12:13:41 -0700")
Roland Dreier <roland@digitalvampire.org> writes:
> > > While reading the MSI code trying to find a reason why MSI wouldn't
> > > work for devices that have a 32-bit MSI address capability, I noticed
> > > that read_msi_msg() seems to read the message data from the wrong
> > > offset in this case.
> >
> > Doh! Sorry about that.
>
> Doesn't matter, it wasn't the bug hitting me anyway :) the IRQ never
> got affinity changed so read_msi_msg() never even got called.
>
> I'm starting to think that Intel 945GM graphics just has a busted MSI
> implementation, although there may be a bug hiding in the Linux code
> that I'm not seeing.
Well it is a bug worth fixing. Who knows it may have something
to do with the disable_irq problems the forcedeth driver was seeing.
Right now MSI is still sufficiently new that everyone is still getting
the bugs out of their implementations.
Eric
next prev parent reply other threads:[~2007-10-03 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87abr0oyj4.fsf@shaolin.home.digitalvampire.org>
2007-10-03 18:25 ` MSI: Use correct data offset for 32-bit MSI in read_msi_msg() Eric W. Biederman
2007-10-03 19:13 ` Roland Dreier
2007-10-03 19:55 ` Eric W. Biederman [this message]
2007-10-03 20:03 ` Roland Dreier
2007-10-03 20:34 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17im4c6sh.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=roland@digitalvampire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.