From: ebiederm+eric@npwt.net (Eric W. Biederman)
To: "Stephen C. Tweedie" <sct@dcs.ed.ac.uk>
Cc: Bill Hawes <whawes@star.net>, linux-mm@kvack.org
Subject: Re: patch for 2.1.102 swap code
Date: 25 May 1998 07:38:40 -0500 [thread overview]
Message-ID: <m190nq4jan.fsf@flinx.npwt.net> (raw)
In-Reply-To: "Stephen C. Tweedie"'s message of Sun, 24 May 1998 18:28:48 +0100
>>>>> "ST" == Stephen C Tweedie <sct@dcs.ed.ac.uk> writes:
ST> On Thu, 21 May 1998 14:56:48 -0400, Bill Hawes <whawes@star.net> said:
>> In try_to_unuse_page there were some problems with swap counts still
>> non-zero after replacing all of the process references to a page,
>> apparently due to the swap map count being elevated while swapping is in
>> progress. (It shows up if a swapoff command is run while the system is
>> swapping heavily.) I've modified the code to make multiple passes in the
>> event that pages are still in use, and to report EBUSY if the counts
>> can't all be cleared.
ST> Hmm. That shouldn't be a problem if everything is working correctly.
ST> However, your first change (the extra swap_duplicate) will leave the
ST> swap count elevated while swapin is occurring, and that could certainly
ST> lead to this symptom in swapoff(). Does the swapoff problem still occur
ST> on an unmodified kernel?
Note: there is a problem with swapoff that should at least be considered.
If you use have a SYSV shared memory, and don't map it into a process,
and that memory get's swapped out, swapoff will not be able to find it.
This is a very long standing bug and appears not to be a problem in practice.
But it is certainly a potential problem.
Eric
next prev parent reply other threads:[~1998-05-25 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <356478F0.FE1C378F@star.net>
1998-05-24 17:28 ` patch for 2.1.102 swap code Stephen C. Tweedie
1998-05-25 10:07 ` David S. Miller
1998-05-25 12:38 ` Eric W. Biederman [this message]
1998-05-26 21:52 ` Stephen C. Tweedie
1998-06-11 14:31 ` Eric W. Biederman
1998-06-12 21:29 ` Stephen C. Tweedie
1998-05-25 12:52 ` Bill Hawes
1998-05-25 13:42 ` David S. Miller
1998-05-26 18:00 ` Stephen C. Tweedie
1998-05-26 21:38 ` Stephen C. Tweedie
1998-05-26 21:46 ` Rik van Riel
1998-06-02 22:21 ` Stephen C. Tweedie
1998-05-27 15:27 ` Bill Hawes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m190nq4jan.fsf@flinx.npwt.net \
--to=ebiederm+eric@npwt.net \
--cc=linux-mm@kvack.org \
--cc=sct@dcs.ed.ac.uk \
--cc=whawes@star.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.