From: ebiederm@xmission.com (Eric W. Biederman)
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
containers@lists.osdl.org, fweisbec@gmail.com,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
srostedt@redhat.com,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 1/3] ftrace: add function tracing to single thread
Date: Tue, 25 Nov 2008 22:23:16 -0800 [thread overview]
Message-ID: <m1abbnc8ff.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0811260000400.26424@gandalf.stny.rr.com> (Steven Rostedt's message of "Wed, 26 Nov 2008 00:01:08 -0500 (EST)")
Steven Rostedt <rostedt@goodmis.org> writes:
> On Tue, 25 Nov 2008, Eric W. Biederman wrote:
>
>>
>>
>
> I'm speechless too.
I'm a bit tired so probably am pushing to hard.
At the same time I don't see a single reason not to use
struct pid for what it was designed for. Identifying tasks.
pid_t's really only belong at the border.
I can see in the tracer when grabbing numbers you might
not be able to follow pointers. For that I see justification
for using task->pid. For the comparison I just don't see it.
Eric
next prev parent reply other threads:[~2008-11-26 6:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 22:34 [PATCH 0/3] ftrace: new features Steven Rostedt
2008-11-25 22:34 ` [PATCH 1/3] ftrace: add function tracing to single thread Steven Rostedt
2008-11-25 22:42 ` Andrew Morton
2008-11-25 23:01 ` Steven Rostedt
2008-11-25 23:31 ` Andrew Morton
2008-11-26 0:11 ` Steven Rostedt
2008-11-26 0:53 ` Dave Hansen
2008-11-26 1:01 ` Steven Rostedt
2008-11-26 4:50 ` Eric W. Biederman
2008-11-26 5:01 ` Steven Rostedt
2008-11-26 6:23 ` Eric W. Biederman [this message]
2008-11-26 6:32 ` Ingo Molnar
2008-11-26 7:02 ` Eric W. Biederman
2008-11-26 7:18 ` Ingo Molnar
2008-11-26 8:48 ` Eric W. Biederman
2008-11-26 5:20 ` Eric W. Biederman
2008-11-26 16:36 ` Steven Rostedt
2008-11-26 0:02 ` Frédéric Weisbecker
2008-11-26 0:16 ` Steven Rostedt
2008-11-25 22:34 ` [PATCH 2/3] ftrace: use code patching for ftrace return tracer Steven Rostedt
2008-11-26 0:13 ` Frédéric Weisbecker
2008-11-26 0:23 ` Steven Rostedt
2008-11-25 22:34 ` [PATCH 3/3] ftrace: let function tracing and function return run together Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1abbnc8ff.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.