All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Neil Horman <nhorman@redhat.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Simon Horman <horms@verge.net.au>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>,
	linux-driver@qlogic.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: In place kexec
Date: Thu, 29 Jul 2010 21:41:59 -0700	[thread overview]
Message-ID: <m1d3u5ins8.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4C524934.5070806@zytor.com> (H. Peter Anvin's message of "Thu\, 29 Jul 2010 20\:38\:28 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:

> On 07/29/2010 12:55 PM, Randy Dunlap wrote:
>>>
>>> And device_shutdown calls every drivers .shutdown method.
>>>
>>> Things like this are always a driver problem.
>> 
>> so is there a default .shutdown method for drivers that do not specify one?
>> 
>> like the qla2xxx driver does not.
>> 
>
> If it doesn't, even if bus mastering gets shut off at the core level,
> there is a risk that is clobbers data when it turns it back on if the
> initialization sequence is problematic.

There isn't a bus master shut off at the core level.  When we did
the original analysis it turned out that the bus mastering bit
was implemented on a lot of devices in advisory way, so it didn't
make sense to count on it.

That said it looks like the code to do the shutdown is in
qla2x00_remove_one so it should be too hard if someone cared to
extract just the hardware bits.

Eric


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2010-07-30  4:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 21:57 In place kexec H. Peter Anvin
2010-07-28 22:02 ` Eric W. Biederman
2010-07-29 13:43   ` Neil Horman
2010-07-29 15:03     ` H. Peter Anvin
2010-07-29 15:06       ` Neil Horman
2010-07-29 17:51         ` H. Peter Anvin
2010-07-29 18:06           ` Eric W. Biederman
2010-07-29 18:29             ` H. Peter Anvin
2010-07-29 19:16               ` Vivek Goyal
2010-07-29 19:51                 ` Eric W. Biederman
2010-07-29 19:55                   ` Randy Dunlap
2010-07-30  3:38                     ` H. Peter Anvin
2010-07-30  4:41                       ` Eric W. Biederman [this message]
2010-07-30  5:04                         ` H. Peter Anvin
2010-07-30 16:30                           ` Eric W. Biederman
2010-07-30 16:41                             ` H. Peter Anvin
2010-07-30 18:36                               ` Eric W. Biederman
2010-07-30 22:52                                 ` Andrew Vasquez
2010-07-30 23:25                                   ` H. Peter Anvin
2010-07-30 23:40                                     ` Eric W. Biederman
2010-07-30 16:53                         ` David Woodhouse
2010-07-30 18:21                           ` Eric W. Biederman
2010-07-30 18:34                             ` Vivek Goyal
2010-07-30 18:50                               ` David Woodhouse
2010-07-30 18:56                                 ` Vivek Goyal
2010-07-30 19:17                                   ` David Woodhouse
2010-07-30 19:39                                     ` Eric W. Biederman
2010-07-30 19:46                                       ` David Woodhouse
2010-07-30 20:08                                         ` Eric W. Biederman
2010-07-30 20:15                                           ` David Woodhouse
2010-07-30 21:11                                             ` H. Peter Anvin
2010-07-30 20:42                           ` H. Peter Anvin
2010-07-30 21:18                             ` Khalid Aziz
2010-07-30 21:44                               ` Khalid Aziz
     [not found]                                 ` <20120425211512.GA8583@ldl.usa.hp.com>
2012-04-25 22:06                                   ` Vivek Goyal
2010-07-29 20:06                   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1d3u5ins8.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-driver@qlogic.com \
    --cc=nhorman@redhat.com \
    --cc=randy.dunlap@oracle.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.