All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ravikiran G Thirumalai <kiran@scalex86.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] Pad irq_desc to internode cacheline size
Date: Mon, 09 Apr 2007 15:47:52 -0600	[thread overview]
Message-ID: <m1ejmt1apj.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070409135729.a466e9cb.akpm@linux-foundation.org> (Andrew Morton's message of "Mon, 9 Apr 2007 13:57:29 -0700")

Andrew Morton <akpm@linux-foundation.org> writes:

> This will consume nearly 4k per irq won't it?  What is the upper bound
> here, across all configs and all hardware?
>
> Is VSMP the only arch which has ____cacheline_internodealigned_in_smp
> larger than ____cacheline_aligned_in_smp?

Ugh. We set internode aligned to 4k for all of x86_64.

I believe this ups our worst case memory consumption for
the array from 1M to 32M.  Although the low end might be 2M.
I can't recall if an irq_desc takes one cache line or two
after we have put the cpu masks in it.

My gut feel says that what we want to do is delay this until
we are dynamically allocating the array members.  Then we can at
least have the chance of allocating the memory on the proper NUMA
node, and won't need the extra NUMA alignment.

I'm not at all certain I'm impressed by an architecture that has
4K aligned cache lines.  That seems terribly piggy.  We might as
well do distributed shared memory in software on a cluster...

Eric

  reply	other threads:[~2007-04-09 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-09 19:56 [patch] Pad irq_desc to internode cacheline size Ravikiran G Thirumalai
2007-04-09 20:57 ` Andrew Morton
2007-04-09 21:47   ` Eric W. Biederman [this message]
2007-04-09 22:09     ` Ravikiran G Thirumalai
2007-04-09 22:33       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ejmt1apj.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=kiran@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.