Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

[Christophe de Dinechin <dinechin@redhat.com>]

Justin Hibbits writes:

> On Wed, 26 Jun 2019 18:16:36 +0200
> Laurent Vivier <laurent@vivier.eu> wrote:
>
>> Le 26/06/2019 à 18:14, Laurent Vivier a écrit :
>> > Le 07/06/2019 à 20:56, Justin Hibbits a écrit :
>> >> The attached very trivial patch fixes a startup bug that prevents
>> >> at least Qemu 3.1 and later from working on FreeBSD/powerpc64.
>> >>
>> >> - Justin
>> >>
>> >
>> > Please don't send a patch in attachment but inlined in the message
>> > (you may use "git send-email" for that).
>> >
>> > This patch fixes "util: add cacheinfo" that has changed the type
>> > from unsigned to long.
>> >
>> > You can add the following line in the commit message:
>> >
>> > Fixes: b255b2c8a548 ("util: add cacheinfo")
>> >
>> > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>> >
>>
>> CC: author of b255b2c8a548 ("util: add cacheinfo")
>>
>> Thanks,
>> Laurent
>
> Hi Laurent,
>
> Sorry.  I had never used git send-email before, so wasn't comfortable
> with it.  I just updated the commit message with your feedback and used
> git send-email to submit the patch.  I hope everything went well.

FWIW, there is also a handy git-publish script that is worth looking at.
It deals with multiple iterations of a patch and other niceties.

https://github.com/stefanha/git-publish

>
> Thanks for your feedback.
>
> - Justin


--
Cheers,
Christophe de Dinechin (IRC c3d)