From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: arnd@arndb.de, netdev@vger.kernel.org, eric.dumazet@gmail.com,
kaber@trash.net
Subject: Re: [PATCH] net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT
Date: Thu, 03 Feb 2011 18:07:47 -0800 [thread overview]
Message-ID: <m1hbcko8lo.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20110203.171918.28815936.davem@davemloft.net> (David Miller's message of "Thu, 03 Feb 2011 17:19:18 -0800 (PST)")
David Miller <davem@davemloft.net> writes:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Sun, 30 Jan 2011 19:59:53 +0100
>
>> * ip multicast actually needs support for SIOCGETVIFCNT in
>> addition to SIOCGETSGCNT to be complete.
>> * ipv6 multicast needs the same patch as ipv4 multicast for
>> SIOCGETMIFCNT_IN6/SIOCGETSGCNT_IN6.
>>
>> It would probably be a good idea if someone could complete the
>> work on ipv4/v6 multicast compat_ioctl, on top of your patch.
>
> Actually, on top of this, Eric's patch is buggy.
Ouch. Thanks for catching that.
> He defines the "struct compat_sioc_sg_req" but doesn't actually
> use it.
>
> I'll fix that, then take care of the missing cases. Thanks Arnd.
Eric
prev parent reply other threads:[~2011-02-04 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 2:15 [PATCH] net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT Eric W. Biederman
2011-01-30 9:14 ` David Miller
2011-01-30 12:26 ` Arnd Bergmann
2011-01-30 18:15 ` Eric W. Biederman
2011-01-30 18:59 ` Arnd Bergmann
2011-02-04 1:19 ` David Miller
2011-02-04 2:07 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hbcko8lo.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.