From: ebiederm@xmission.com (Eric W. Biederman)
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: change remove NR_IRQS in 8250.c
Date: Thu, 31 Jul 2008 04:50:21 -0700 [thread overview]
Message-ID: <m1iqum2rya.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <200807310126.12572.yhlu.kernel@gmail.com> (Yinghai Lu's message of "Thu, 31 Jul 2008 01:26:12 -0700")
> replace
> [PATCH] serial: change irq_lists to use dyn_array
> use small array with index to handle irq locking for serial port
> hope 32 slot is enough
Could you size this array by NR_UARTS (our worst case usage)
and place irq_no in struct irq_info?
Also you want to hold irq_info->lock when you set or clear irq_no.
Just to be on the safe side. I expect we can avoid clearing the irq_no
in the irq_lists and prevent a few more races from being a possibility.
Eric
next prev parent reply other threads:[~2008-07-31 11:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 21:14 [PATCH] x86: 64bit support more than 256 irq v2 Yinghai Lu
2008-07-29 22:16 ` Yinghai Lu
2008-07-29 23:22 ` Eric W. Biederman
2008-07-30 4:38 ` RFC [PATCH] x86: introduce nr_irqs for 64bit Yinghai Lu
2008-07-30 10:09 ` Ingo Molnar
2008-07-30 10:16 ` Yinghai Lu
2008-07-30 12:58 ` Mike Travis
2008-07-30 10:11 ` [PATCH] x86: introduce nr_irqs for 64bit v2 Yinghai Lu
2008-07-30 19:10 ` [PATCH 0/7] dyn_array support Yinghai Lu
2008-07-30 19:13 ` [PATCH 2/7] x86: introduce nr_irqs for 64bit v3 Yinghai Lu
2008-07-30 19:16 ` [PATCH 5/7] pci: make irq2_iommu to use dyn_array Yinghai Lu
2008-07-30 19:18 ` [PATCH 7/7] x86: make 64bit support dyn_array Yinghai Lu
2008-07-30 19:27 ` [PATCH 1/7] x86: 64bit support more than 256 irq v1 Yinghai Lu
2008-07-30 19:37 ` [PATCH 3/7] add dyn_array support Yinghai Lu
2008-07-30 19:40 ` [PATCH 6/7] irq: make irq_desc to use dyn_array Yinghai Lu
2008-07-30 19:40 ` [PATCH 4/7] random: make irq_timer_state " Yinghai Lu
2008-07-31 4:09 ` [PATCH 0/3] dyn_array support #2 Yinghai Lu
2008-07-31 4:10 ` [PATCH 1/3] serial: change irq_lists to use dyn_array Yinghai Lu
2008-07-31 5:58 ` Eric W. Biederman
2008-07-31 8:26 ` [PATCH] serial: change remove NR_IRQS in 8250.c Yinghai Lu
2008-07-31 11:50 ` Eric W. Biederman [this message]
2008-07-31 13:57 ` Alan Cox
2008-07-31 18:10 ` Eric W. Biederman
2008-07-31 23:15 ` Alan Cox
2008-08-01 3:20 ` Yinghai Lu
2008-07-31 4:11 ` [PATCH 2/3] add per_cpu_dyn_array support Yinghai Lu
2008-07-31 4:12 ` [PATCH 3/3] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-07-31 10:14 ` [PATCH] x86 remove irq_vectors_limit.h Yinghai Lu
2008-07-31 16:32 ` [PATCH 0/3] dyn_array support #2 Mike Travis
2008-07-31 18:21 ` Yinghai Lu
2008-07-31 21:51 ` Peter Zijlstra
2008-07-31 22:07 ` Yinghai Lu
2008-07-31 22:25 ` Yinghai Lu
2008-08-01 3:52 ` Yinghai Lu
2008-07-31 22:14 ` Eric W. Biederman
2008-08-01 20:13 ` [PATCH 0/7] dyn_array support Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1iqum2rya.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.