From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Linux Containers <containers@lists.osdl.org>,
netdev@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [GIT PULL] Namespace file descriptors for 2.6.40
Date: Tue, 24 May 2011 00:03:37 -0700 [thread overview]
Message-ID: <m1k4dgr35i.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20110522084224.GA12279@elte.hu> (Ingo Molnar's message of "Sun, 22 May 2011 10:42:24 +0200")
Ingo Molnar <mingo@elte.hu> writes:
> I agree with Linus's notion in this thread though, a core kernel change should
> generally not worry about hooking up rare-arch system calls (concentrate on the
> architectures that get tested most) - those are better enabled gradually
> anyway.
The way I read it he was complaining about my having parisc bits and
asking for my branch to be merged before the parisc bits had been
merged. Which I credit as a fair complaint. If I am going to depend on
other peoples trees I should wait.
At the same time when I am busy looking for every possible source of
trouble and putting code into net-next to detect pending conflicts,
and when maintainers complain when I ask for review that my patches
conflict with their patches. Being a contentious developer I am
inclined to do something.
Now that the reality has sunk in that it means waiting for other peoples
code to be merged before I request for my changes to be merged I don't
think I will structure a tree that way again while I remember.
> Also, system call table conflicts are trivial to resolve. Merging in net-next
> to avoid such a conflict is like cracking a nut with a sledgehammer.
Well I still have trauma from how nasty it was to test with syscall
numbers continuing to change when I was working on the kexec_load system
call.
As far as I can tell any one system call conflict on any one
architecture is easy to resolve. Resolving a conflict on all
architectures would amount to at least 50 files that need to be resolved
that feels a bit more than trivial.
My gut feel says we should really implement an
include/asm-generic/unistd-common.h to include all new system calls.
That way there would be only one file to touch instead of 50.
Certainly it works for include/asm-generic/unistd.h for the
architectures that use it. And all we really need is just a little
abstraction on that concept.
Eric
next prev parent reply other threads:[~2011-05-24 7:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 23:39 [GIT PULL] Namespace file descriptors for 2.6.40 Eric W. Biederman
2011-05-21 23:39 ` Eric W. Biederman
2011-05-21 23:42 ` Linus Torvalds
2011-05-22 0:33 ` Eric W. Biederman
[not found] ` <m1boyvpo9r.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2011-05-22 7:13 ` James Bottomley
2011-05-22 7:13 ` James Bottomley
2011-05-22 8:42 ` Ingo Molnar
2011-05-24 7:03 ` Eric W. Biederman [this message]
2011-05-24 7:16 ` Ingo Molnar
2011-05-25 0:34 ` Valdis.Kletnieks
2011-05-25 8:25 ` Ingo Molnar
2011-05-25 8:35 ` Geert Uytterhoeven
2011-05-25 12:47 ` Ingo Molnar
2011-05-25 13:00 ` Geert Uytterhoeven
2011-05-25 13:17 ` Ingo Molnar
2011-05-25 15:22 ` Geert Uytterhoeven
2011-05-24 7:26 ` James Bottomley
2011-05-24 8:11 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2011-05-23 21:05 Eric W. Biederman
2011-05-23 21:05 ` Eric W. Biederman
2011-05-25 21:05 ` C Anthony Risinger
2011-05-25 21:38 ` Serge E. Hallyn
2011-05-25 21:55 ` C Anthony Risinger
2011-05-25 22:11 ` Michał Mirosław
2011-05-25 23:40 ` Eric W. Biederman
2011-05-27 20:18 ` C Anthony Risinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k4dgr35i.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=containers@lists.osdl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.