From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by ozlabs.org (Postfix) with ESMTP id A6C2BB7CFD for ; Thu, 11 Mar 2010 06:16:14 +1100 (EST) To: Yinghai Lu Subject: Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. References: <1268218524.11737.68547.camel@zakaz.uk.xensource.com> <1268218559-26784-2-git-send-email-ijc@hellion.org.uk> <86802c441003100406t70dd854fx491f0ee9a6fce62b@mail.gmail.com> <1268225473.11737.69196.camel@zakaz.uk.xensource.com> <4B97EC00.6030300@kernel.org> From: ebiederm@xmission.com (Eric W. Biederman) Date: Wed, 10 Mar 2010 11:15:58 -0800 In-Reply-To: <4B97EC00.6030300@kernel.org> (Yinghai Lu's message of "Wed\, 10 Mar 2010 10\:59\:12 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeremy Fitzhardinge , Ian Campbell , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@ozlabs.org" , Ingo Molnar , Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Yinghai Lu writes: > On 03/10/2010 04:51 AM, Ian Campbell wrote: >> On Wed, 2010-03-10 at 12:06 +0000, Yinghai Lu wrote: >>> On Wed, Mar 10, 2010 at 2:55 AM, wrote: >>>> From: Ian Campbell >>>> >>>> Move arch_init_copy_chip_data and arch_free_chip_data into function >>>> pointers in struct irq_chip since they operate on irq_desc->chip_data. >>>> >>>> arch_init_chip_data cannot be moved into struct irq_chip at this time >>>> because irq_desc->chip is not known at the time the irq_desc is >>>> setup. For now rename arch_init_chip_data to arch_init_irq_desc (for >>>> PowerPC, the only other user, whose usage better matches the new name) >>>> and on x86 convert arch_init_chip_data to ioapic_init_chip_data and >>>> call this whenever the IO APIC code allocates a new IRQ. >>>> >>>> I've retained the chip_data behaviour for uv_irq although it isn't >>>> clear to me if these interrupt types support migration or how closely >>>> related to the APIC modes they really are. If it weren't for this the >>>> ioapic_{init,copy,free}_chip_data functions could be static to >>>> io_apic.c. >>>> >>>> I've tested by booting on a 64 bit system, but it's not clear to me >>>> what actions I need to take to actually exercise some of these code >>>> paths. >>>> >>> >>> can you just add another pointer field in irq_desc? >>> >>> some kind of *irq_info etc. >> >> I think I don't understand what you are suggesting. >> >> There is already a pointer for irq_chip specific use i.e. >> irq_desc->chip_data. This patchset is just about ensuring that the field >> really is available to any chip implementation rather than just assuming >> it is always used for the acpi chip types (on x86 at least). >> >> Does adding a second pointer with the same (intended?) semantics as the >> existing one buy us anything? > > > #ifdef CONFIG_INTR_REMAP > struct irq_2_iommu *irq_2_iommu; > #endif > struct irq_chip *chip; > struct msi_desc *msi_desc; > > we already have that for irq_2_iommu and msi_desc Those are at different levels of the hierarchy. Adding another pointer for Xen is like having a different iommu and so adding another pointer to handle that kind of iommu. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087Ab0CJTQP (ORCPT ); Wed, 10 Mar 2010 14:16:15 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:42534 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183Ab0CJTQN (ORCPT ); Wed, 10 Mar 2010 14:16:13 -0500 To: Yinghai Lu Cc: Ian Campbell , "linux-kernel\@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jeremy Fitzhardinge , Benjamin Herrenschmidt , Paul Mackerras , "x86\@kernel.org" , "linuxppc-dev\@ozlabs.org" Subject: Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. References: <1268218524.11737.68547.camel@zakaz.uk.xensource.com> <1268218559-26784-2-git-send-email-ijc@hellion.org.uk> <86802c441003100406t70dd854fx491f0ee9a6fce62b@mail.gmail.com> <1268225473.11737.69196.camel@zakaz.uk.xensource.com> <4B97EC00.6030300@kernel.org> From: ebiederm@xmission.com (Eric W. Biederman) Date: Wed, 10 Mar 2010 11:15:58 -0800 In-Reply-To: <4B97EC00.6030300@kernel.org> (Yinghai Lu's message of "Wed\, 10 Mar 2010 10\:59\:12 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Rcpt-To: yinghai@kernel.org, linuxppc-dev@ozlabs.org, x86@kernel.org, paulus@samba.org, benh@kernel.crashing.org, jeremy@goop.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, Ian.Campbell@citrix.com X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on in02.mta.xmission.com); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yinghai Lu writes: > On 03/10/2010 04:51 AM, Ian Campbell wrote: >> On Wed, 2010-03-10 at 12:06 +0000, Yinghai Lu wrote: >>> On Wed, Mar 10, 2010 at 2:55 AM, wrote: >>>> From: Ian Campbell >>>> >>>> Move arch_init_copy_chip_data and arch_free_chip_data into function >>>> pointers in struct irq_chip since they operate on irq_desc->chip_data. >>>> >>>> arch_init_chip_data cannot be moved into struct irq_chip at this time >>>> because irq_desc->chip is not known at the time the irq_desc is >>>> setup. For now rename arch_init_chip_data to arch_init_irq_desc (for >>>> PowerPC, the only other user, whose usage better matches the new name) >>>> and on x86 convert arch_init_chip_data to ioapic_init_chip_data and >>>> call this whenever the IO APIC code allocates a new IRQ. >>>> >>>> I've retained the chip_data behaviour for uv_irq although it isn't >>>> clear to me if these interrupt types support migration or how closely >>>> related to the APIC modes they really are. If it weren't for this the >>>> ioapic_{init,copy,free}_chip_data functions could be static to >>>> io_apic.c. >>>> >>>> I've tested by booting on a 64 bit system, but it's not clear to me >>>> what actions I need to take to actually exercise some of these code >>>> paths. >>>> >>> >>> can you just add another pointer field in irq_desc? >>> >>> some kind of *irq_info etc. >> >> I think I don't understand what you are suggesting. >> >> There is already a pointer for irq_chip specific use i.e. >> irq_desc->chip_data. This patchset is just about ensuring that the field >> really is available to any chip implementation rather than just assuming >> it is always used for the acpi chip types (on x86 at least). >> >> Does adding a second pointer with the same (intended?) semantics as the >> existing one buy us anything? > > > #ifdef CONFIG_INTR_REMAP > struct irq_2_iommu *irq_2_iommu; > #endif > struct irq_chip *chip; > struct msi_desc *msi_desc; > > we already have that for irq_2_iommu and msi_desc Those are at different levels of the hierarchy. Adding another pointer for Xen is like having a different iommu and so adding another pointer to handle that kind of iommu. Eric