From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [RFC][patch 0/1] fix allnoconfig for net-2.6.24 Date: Wed, 12 Sep 2007 11:23:41 -0600 Message-ID: References: <20070912170739.187625566@mai.toulouse-stg.fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20070912170739.187625566-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org> (dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org's message of "Wed, 12 Sep 2007 19:07:39 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org writes: > The kernel compilation fails with allnoconfig with an unresolved to init_net. > I tryed to figure out how to fix that. The problem is raised because the > init_net > variable is defined as extern in net_namespace.h while the variable is declared > in net_namespace.c. This file is not compiled because of the config options and > that leads to the compilation error. > > I noticed the uts namespace defines the init_uts_ns in init/version.c, so I > moved > the init_net to this file too. The compilation error is fixed. > > But I don't like really this approach because: > 1 - we fall under a part not covered by the network > 2 - we add a new include net_namespace.h in version.c > > Does this fix seems correct ? I just want to fix it for now to have net-2.6.24 > compiling for all configs. Thanks for the testing and catching all of the little nit picky things. Where is init_net used that is a problem with allnoconfig? Eric