From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756338AbYHUGYP (ORCPT ); Thu, 21 Aug 2008 02:24:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753672AbYHUGX7 (ORCPT ); Thu, 21 Aug 2008 02:23:59 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:39263 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753332AbYHUGX7 (ORCPT ); Thu, 21 Aug 2008 02:23:59 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Andi Kleen" Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, Andi Kleen References: <1218865985-23403-1-git-send-email-andi@firstfloor.org> Date: Wed, 20 Aug 2008 23:14:36 -0700 In-Reply-To: <1218865985-23403-1-git-send-email-andi@firstfloor.org> (Andi Kleen's message of "Sat, 16 Aug 2008 07:53:05 +0200") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Andi Kleen" X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH] Move sysctl check into debugging section and don't make it default y X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Andi Kleen" writes: > From: Andi Kleen > > I noticed that sysctl_check.o was the largest object file in > a allnoconfig build in kernel/*. > > 36243 0 0 36243 8d93 kernel/sysctl_check.o > > This is because it was default y and && EMBEDDED. But I don't > really see a need for a non kernel developer to have their > sysctls checked all the time. What is a feature change like this doing coming in after the merge window? Why doesn't an allnoconfig disable sysctl all together? > So move the Kconfig into the kernel debugging section and > also drop the default y and the EMBEDDED check. Which is an idiotic thing to do. These are the only checks we have against someone doing something nasty in the sysctl hierarchy. We have proven that we don't have the discipline to do the right thing with code in the core kernel. I expect out of tree code will be much worse. Eric