From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 2/5] pid: use namespaced iteration on processes while using sysrq Date: Thu, 18 Dec 2008 09:31:04 -0800 Message-ID: References: <1229618553-6348-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <1229618553-6348-3-git-send-email-gowrishankar.m@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1229618553-6348-3-git-send-email-gowrishankar.m-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> (Gowrishankar M.'s message of "Thu, 18 Dec 2008 22:12:30 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Gowrishankar M Cc: Containers , Dave , Sukadev , Balbir List-Id: containers.vger.kernel.org Gowrishankar M writes: > From: Gowrishankar M > > At present, while signalling processes using sysrq, process iteration > goes beyond current PID namespace. > > Below patch uses one of the proposed namespace iteration macros to fix > the boundary. > > Signed-off-by: Gowrishankar M Nacked-by: "Eric W. Biederman" sysrq is a debugging helper and send_sig_all should apply to ever process in the system. It should only apply to the initial pid namespace. Attempting to make it namespace aware is wrong. Eric