From: ebiederm@xmission.com (Eric W. Biederman)
To: Daniel Lezcano <dlezcano@fr.ibm.com>
Cc: davem@davemloft.net, containers@lists.osdl.org, netdev@vger.kernel.org
Subject: Re: [patch 1/1][NETNS] resend: fix net released by rcu callback
Date: Tue, 30 Oct 2007 14:47:34 -0600 [thread overview]
Message-ID: <m1odegl47t.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071030162305.458123510@mai.toulouse-stg.fr.ibm.com> (Daniel Lezcano's message of "Tue, 30 Oct 2007 17:21:40 +0100")
Daniel Lezcano <dlezcano@fr.ibm.com> writes:
> When a network namespace reference is held by a network subsystem,
> and when this reference is decremented in a rcu update callback, we
> must ensure that there is no more outstanding rcu update before
> trying to free the network namespace.
>
> In the normal case, the rcu_barrier is called when the network namespace
> is exiting in the cleanup_net function.
>
> But when a network namespace creation fails, and the subsystems are
> undone (like the cleanup), the rcu_barrier is missing.
>
> This patch adds the missing rcu_barrier.
Looks sane. Did you have any specific failures related to this or was
this something that was just caught in review?
Eric
next prev parent reply other threads:[~2007-10-30 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071030162139.954791193@mai.toulouse-stg.fr.ibm.com>
2007-10-30 16:21 ` [patch 1/1][NETNS] resend: fix net released by rcu callback Daniel Lezcano
2007-10-30 20:47 ` Eric W. Biederman [this message]
2007-10-30 21:43 ` Daniel Lezcano
2007-10-30 22:34 ` Eric W. Biederman
2007-10-30 22:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1odegl47t.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dlezcano@fr.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.