From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown Date: 01 Mar 2005 04:12:50 -0700 Message-ID: References: <20050228231721.GA1326@elf.ucw.cz> <20050301015231.091b5329.akpm@osdl.org> <20050301105448.GG1345@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20050301105448.GG1345-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Pavel Machek Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, barryn-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, marado-oe7qfRrRQfcmha6Ds7sm0l6hYfS7NtTn@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Len Brown List-Id: linux-acpi@vger.kernel.org Pavel Machek writes: > Yes, the patch is very ugly. If something like this needs to be done, > then perhaps acpi should properly register into driver model and do > the work there. This will also mean code will be called consistently. I totally agree. Do you have an example of how a non-device can do this? In particular something that gets as close to shutting down the system devices as possible. But gets called before that. Or perhaps acpi should simply be setup to be the first system device? Eric ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261873AbVCALQM (ORCPT ); Tue, 1 Mar 2005 06:16:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261874AbVCALQM (ORCPT ); Tue, 1 Mar 2005 06:16:12 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:18637 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S261873AbVCALQF (ORCPT ); Tue, 1 Mar 2005 06:16:05 -0500 To: Pavel Machek Cc: Andrew Morton , linux-kernel@vger.kernel.org, barryn@pobox.com, marado@student.dei.uc.pt, acpi-devel@lists.sourceforge.net, Len Brown Subject: Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown References: <20050228231721.GA1326@elf.ucw.cz> <20050301015231.091b5329.akpm@osdl.org> <20050301105448.GG1345@elf.ucw.cz> From: ebiederm@xmission.com (Eric W. Biederman) Date: 01 Mar 2005 04:12:50 -0700 In-Reply-To: <20050301105448.GG1345@elf.ucw.cz> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek writes: > Yes, the patch is very ugly. If something like this needs to be done, > then perhaps acpi should properly register into driver model and do > the work there. This will also mean code will be called consistently. I totally agree. Do you have an example of how a non-device can do this? In particular something that gets as close to shutting down the system devices as possible. But gets called before that. Or perhaps acpi should simply be setup to be the first system device? Eric