From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg KH <gregkh@suse.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for June 3 (driver core)
Date: Wed, 03 Jun 2009 14:44:55 -0700 [thread overview]
Message-ID: <m1skihm1pk.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090603212206.GA20804@suse.de> (Greg KH's message of "Wed\, 3 Jun 2009 14\:22\:06 -0700")
Greg KH <gregkh@suse.de> writes:
> On Wed, Jun 03, 2009 at 08:50:10AM -0700, Randy Dunlap wrote:
>> Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > Looks like a real rush since -rc7 ...
>>
>>
>> drivers/built-in.o: In function `register_mem_sect_under_node':
>> (.text+0x1d305b): undefined reference to `sysfs_create_link_nowarn'
>>
>>
>> I can't find this function's implementation when CONFIG_SYSFS=y.
>
> Ah, it looks like this shows up when CONFIG_MEMORY_HOTPLUG_SPARSE is
> set.
>
> Eric, your patch, "sysfs: Remove now unnecessary error reporting
> suppression." caused this. Turns out it is still used in the tree, and
> you forgot to remove the function from sysfs.h at the same time.
>
> I'm going to drop it, and the other two patches I took from you for
> sysfs, as it doesn't make sense to have them in the tree yet.
>
> Care to rework your series with this fixed?
Sure.
My apologies it looks like sysfs_create_link_nowarn grew an extra
user since last time I audited that patch thoroughly.
How I missed the header I don't know.
Eric
prev parent reply other threads:[~2009-06-03 21:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 9:09 linux-next: Tree for June 3 Stephen Rothwell
2009-06-03 15:22 ` linux-next: Tree for June 3 (rfkill) Randy Dunlap
2009-06-03 15:29 ` Johannes Berg
[not found] ` <1244042950.4862.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 15:47 ` Gábor Stefanik
2009-06-03 15:47 ` Gábor Stefanik
2009-06-03 15:53 ` Johannes Berg
[not found] ` <4A269539.8020607-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-06-03 16:27 ` Johannes Berg
2009-06-03 16:27 ` Johannes Berg
2009-06-03 17:20 ` Randy Dunlap
2009-06-03 17:20 ` Randy Dunlap
2009-06-03 17:33 ` Johannes Berg
[not found] ` <1244050400.22105.0.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 22:48 ` Inaky Perez-Gonzalez
2009-06-03 22:48 ` Inaky Perez-Gonzalez
2009-06-03 15:24 ` linux-next: Tree for June 3 (staging) Randy Dunlap
2009-06-03 15:25 ` Greg KH
2009-06-03 15:40 ` Randy Dunlap
2009-06-03 23:11 ` Greg KH
2009-06-04 2:04 ` Gao, Yunpeng
2009-06-04 2:04 ` Gao, Yunpeng
2009-06-04 23:26 ` Yunpeng Gao
2009-06-04 16:00 ` Greg KH
2009-06-04 17:52 ` Greg KH
2009-06-05 3:31 ` Gao, Yunpeng
2009-06-05 18:58 ` Bartlomiej Zolnierkiewicz
2009-06-05 19:22 ` Greg KH
2009-06-06 16:30 ` Yunpeng Gao
2009-06-06 8:37 ` Gao, Yunpeng
2009-06-04 22:07 ` mISDN: WARNING: at kernel/softirq.c:124 local_bh_enable+0x8f/0xb0() Mathias Kretschmer
2009-06-05 2:59 ` Andrew Morton
2009-06-05 10:01 ` Karsten Keil
2009-06-09 13:05 ` Karsten Keil
2009-06-22 22:37 ` Mathias Kretschmer
2009-06-05 18:45 ` linux-next: Tree for June 3 (staging) Bartlomiej Zolnierkiewicz
2009-06-05 20:15 ` Alan Cox
2009-06-06 8:35 ` Gao, Yunpeng
2009-06-03 15:44 ` linux-next: Tree for June 3 (staging++) Randy Dunlap
2009-06-03 15:50 ` linux-next: Tree for June 3 (driver core) Randy Dunlap
2009-06-03 21:22 ` Greg KH
2009-06-03 21:44 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1skihm1pk.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.