From: ebiederm@xmission.com (Eric W. Biederman)
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc 1/6: implement support for automounts in task directories
Date: Mon, 30 Mar 2009 16:10:59 -0700 [thread overview]
Message-ID: <m1skkuhaik.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090330225326.GB19892@x200.localdomain> (Alexey Dobriyan's message of "Tue\, 31 Mar 2009 02\:53\:26 +0400")
Alexey Dobriyan <adobriyan@gmail.com> writes:
> I don't have a lot of opinion on this bug. I checked patchset to fix known
> reproducer, timeout is obviously taken out of air and not nice.
As for timeout. The logic is that mark_mounts_for_expiry is just an
aging mechanism, and if something is actually in use it is not aged out.
In the general case the call to proc_shrink_automounts in
kernel/exit.c will clean up everything. It is possible but unlikely
in practice that someone will pin a lot of process directories open
then stop pinning them, and after that point nothing will remain open,
so we close that hole.
I set timeout huge because it should never be needed in real life.
That said I'm up for taking this as a starting point and generalizing
the mechanisms in fs/namespace.c. So I don't need a timeout at all,
but that is an orthogonal discussion.
Eric
next prev parent reply other threads:[~2009-03-30 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 22:53 [PATCH] proc 1/6: implement support for automounts in task directories Alexey Dobriyan
2009-03-30 23:07 ` Eric W. Biederman
2009-03-30 23:10 ` Eric W. Biederman [this message]
2009-04-08 12:16 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1skkuhaik.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.