All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Dave Jones <davej@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: tickle nmi watchdog whilst doing serial writes.
Date: Sun, 15 May 2005 13:38:02 +0200	[thread overview]
Message-ID: <m1u0l4afdx.fsf@muc.de> (raw)
In-Reply-To: <20050513184806.GA24166@redhat.com> (Dave Jones's message of "Fri, 13 May 2005 14:48:06 -0400")

Dave Jones <davej@redhat.com> writes:
>  
>  #include <asm/io.h>
>  #include <asm/irq.h>
> @@ -2099,8 +2100,10 @@ static inline void wait_for_xmitr(struct
>  	if (up->port.flags & UPF_CONS_FLOW) {
>  		tmout = 1000000;
>  		while (--tmout &&
> -		       ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0))
> +		       ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0)) {
>  			udelay(1);
> +			touch_nmi_watchdog();

Note that touch_nmi_watchdog is not exported on i386 - Linus vetoed
that some time ago. The real fix of course is to use schedule_timeout(),
but that might break printk() with interrupts off :/

-Andi

  parent reply	other threads:[~2005-05-15 11:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-13 18:48 tickle nmi watchdog whilst doing serial writes Dave Jones
2005-05-13 19:14 ` Arjan van de Ven
2005-05-13 19:23   ` Dave Jones
2005-05-13 19:37   ` Russell King
2005-05-14  6:43 ` Andrew Morton
2005-05-14  6:57   ` Dave Jones
2005-05-14  7:07     ` Andrew Morton
2005-05-14 10:31       ` Ed Tomlinson
2005-05-14 10:53         ` Alexander Nyberg
2005-05-15 11:40           ` Andi Kleen
2005-05-14 10:53         ` Ed Tomlinson
2005-05-15 11:38 ` Andi Kleen [this message]
2005-05-15 12:07   ` Russell King
2005-05-15 12:20     ` Andi Kleen
2005-05-15 14:01       ` Russell King
2005-05-15 14:03         ` Andi Kleen
2005-05-19  0:24       ` George Anzinger
2005-05-19  7:33         ` Russell King
2005-05-23 20:20           ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1u0l4afdx.fsf@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.