From: Nikita Danilov <nikita@clusterfs.com>
To: linux-kernel@vger.kernel.org
Cc: bunk@stusta.de, Andrew Morton <akpm@osdl.org>, reiserfs-dev@namesys.com
Subject: Re: [2.6.11-rc5-mm1 patch] reiser4 Kconfig help cleanup
Date: Wed, 02 Mar 2005 17:29:08 +0300 [thread overview]
Message-ID: <m1vf8aktor.fsf@clusterfs.com> (raw)
In-Reply-To: <20050302011448.37f1e951.akpm@osdl.org> (Andrew Morton's message of "Wed, 2 Mar 2005 01:14:48 -0800")
Andrew Morton <akpm@osdl.org> writes:
> Jes Sorensen <jes@wildopensource.com> wrote:
>>
[...]
>>
>> [jes@tomahawk linux-2.6.11-rc5-mm1]$ grep PG_arch fs/reiser4/*.c
>> fs/reiser4/page_cache.c: page_flag_name(page, PG_arch_1),
>> fs/reiser4/txnmgr.c: assert("vs-1448", test_and_clear_bit(PG_arch_1, &node->pg->flags));
>> fs/reiser4/txnmgr.c: ON_DEBUG(set_bit(PG_arch_1, &(copy->pg)->flags));
>>
>> Someone was obviously smoking something illegal, what part of 'arch'
>> did she/he not understand? I assume we can request this is fixed by
>> the patch owner asap.
>>
>
> Could the reiserfs team please comment?
>
> If it's just debug then probably it would be better to add a new flag.
>
Yes, this is debugging. I believe it can be removed now.
> If these pages are never mmapped then it'll just happen to work, I guess.
> But a filesystem really shouldn't be dinking with PG_arch_1.
Nikita.
next prev parent reply other threads:[~2005-03-02 14:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-01 9:27 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 13:36 ` 2.6.11-rc5-mm1 Valdis.Kletnieks
2005-03-01 13:55 ` 2.6.11-rc5-mm1 Russell King
2005-03-01 15:18 ` 2.6.11-rc5-mm1 Valdis.Kletnieks
2005-03-01 15:27 ` 2.6.11-rc5-mm1 Russell King
2005-03-01 20:42 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 20:45 ` 2.6.11-rc5-mm1 Greg KH
2005-03-01 13:53 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 13:53 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:00 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:00 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:06 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 14:06 ` 2.6.11-rc5-mm1 Mathieu Segaud
2005-03-01 15:06 ` 2.6.11-rc5-mm1 Edward Shishkin
2005-03-01 15:53 ` 2.6.11-rc5-mm1 (compile stats) John Cherry
2005-03-01 17:40 ` 2.6.11-rc5-mm1 Aurélien Francillon
2005-03-02 8:53 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-02 15:45 ` 2.6.11-rc5-mm1 Andreas Gruenbacher
2005-03-03 11:01 ` 2.6.11-rc5-mm1 Aurélien Francillon
2005-03-01 20:16 ` 2.6.11-rc5-mm1 Adrian Bunk
2005-03-01 21:58 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-01 21:49 ` 2.6.11-rc5-mm1 Chris Wright
2005-03-01 22:08 ` 2.6.11-rc5-mm1 Andrew Morton
2005-03-03 8:04 ` 2.6.11-rc5-mm1 Jeff Dike
2005-03-03 16:21 ` 2.6.11-rc5-mm1 Chris Wright
2005-03-03 19:25 ` 2.6.11-rc5-mm1 Jeff Dike
2005-03-03 19:14 ` 2.6.11-rc5-mm1 Chris Wright
2005-03-04 11:01 ` 2.6.11-rc5-mm1 zwx
2005-03-01 23:43 ` [2.6.11-rc5-mm1 patch] reiser4 Kconfig help cleanup Adrian Bunk
2005-03-02 9:01 ` Jes Sorensen
2005-03-02 9:14 ` Andrew Morton
2005-03-02 14:29 ` Nikita Danilov [this message]
2005-03-02 14:40 ` [2.6.11-rc5-mm1 patch] reiser4 cleanup (PG_arch_1) Vladimir Saveliev
2005-03-03 13:17 ` [2.6.11-rc5-mm1 patch] fs/reiser4/: possible cleanups Adrian Bunk
2005-03-03 13:22 ` [2.6.11-rc5-mm1 patch] drivers/acpi/pcc_acpi.c: section fixes Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1vf8aktor.fsf@clusterfs.com \
--to=nikita@clusterfs.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.