From: ebiederm@xmission.com (Eric W. Biederman)
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: webmaster@dragonslave.de, akpm <akpm@linux-foundation.org>,
Daniel Exner <dex@dragonslave.de>,
linux-kernel@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Michal Januszewski <spock@gentoo.org>
Subject: Re: [PATCH] sysctl: fix token-ring procname
Date: Sun, 28 Oct 2007 16:44:29 -0600 [thread overview]
Message-ID: <m1wst6q2pe.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071028152533.7606cf45.randy.dunlap@oracle.com> (Randy Dunlap's message of "Sun, 28 Oct 2007 15:25:33 -0700")
Randy Dunlap <randy.dunlap@oracle.com> writes:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Eric W. Biederman <ebiederm@xmission.com>
>
> Correct the token-ring sysctl procname.
>
> Reported by: Daniel Exner <dex@dragonslave.de>:
>
> Ah, and token ring tells me something like
> "/net/token-ring ,3.14 sysctl failed check procname does not match binary path
> procname"
> But kernel boots otherwise and I got no chance to test tr itself is working.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
"token-ring" is the historical name we have used in /proc/sys despite it
being abbreviated tr in the kernel. So this fix is definitely
correct.
Sorry about that. Given this bug and the atalk bug it looks like
I failed to QA the number to name mapping properly under net/.
I just looked at those entries again and I don't see any other
entries under net/ that have problems.
Hopefully this is the last of my silly bugs in this table.
Eric
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> kernel/sysctl_check.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.24-rc1.orig/kernel/sysctl_check.c
> +++ linux-2.6.24-rc1/kernel/sysctl_check.c
> @@ -738,7 +738,7 @@ static struct trans_ctl_table trans_net_
> { NET_ROSE, "rose", trans_net_rose_table },
> { NET_IPV6, "ipv6", trans_net_ipv6_table },
> { NET_X25, "x25", trans_net_x25_table },
> - { NET_TR, "tr", trans_net_tr_table },
> + { NET_TR, "token-ring", trans_net_tr_table },
> { NET_DECNET, "decnet", trans_net_decnet_table },
> /* NET_ECONET not used */
> { NET_SCTP, "sctp", trans_net_sctp_table },
prev parent reply other threads:[~2007-10-28 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 18:37 Uvesafb and token-ring in 2.6.24-rc1 broken Daniel Exner
2007-10-28 22:25 ` [PATCH] sysctl: fix token-ring procname Randy Dunlap
2007-10-28 22:44 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wst6q2pe.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dex@dragonslave.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=spock@gentoo.org \
--cc=webmaster@dragonslave.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.